Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Apr 2021 18:48:28 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <CAL_JsqKne=ASOyd0E9GakVvDvaXDauHOOU5NgxU8X8ySvyrAcw@mail.gmail.com>
References: <20210419154659.44096-1-ilya.lipnitskiy@gmail.com> <20210419154659.44096-3-ilya.lipnitskiy@gmail.com> <20210420195132.GA3686955@robh.at.kernel.org> <CALCv0x2SG=0kBRnxfSPxi+FvaBK=QGPHQkHWHvTXOw64KawPUQ@mail.gmail.com> <trinity-47c2d588-093d-4054-a16f-81d76aa667e0-1619013874284@3c-app-gmx-bs34> <CAL_JsqKne=ASOyd0E9GakVvDvaXDauHOOU5NgxU8X8ySvyrAcw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: Re: [PATCH net-next v2 2/2] net: ethernet: mediatek: support custom GMAC label
Reply-to: frank-w@public-files.de
To:     linux-mediatek@lists.infradead.org, Rob Herring <robh@kernel.org>
CC:     Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, Felix Fietkau <nbd@nbd.name>,
        John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        netdev <netdev@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        =?ISO-8859-1?Q?Ren=E9_van_Dorst?= <opensource@vdorst.com>
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <278445B7-727F-444D-8F5F-986CAD38BA57@public-files.de>
Precedence: bulk

Am 21=2E April 2021 18:12:41 MESZ schrieb Rob Herring <robh@kernel=2Eorg>:
>On Wed, Apr 21, 2021 at 9:05 AM Frank Wunderlich
><frank-w@public-files=2Ede> wrote:
>>
>> Hi,
>>
>> for dsa slave-ports there is already a property "label", but not for
>master/cpu-ports
>
>Is that because slave ports are external and master are not? If so,
>that makes sense=2E

In my case gmac is internal,yes=2E=2E=2Ei don't know if ilyas device is si=
milar=2E

But in a previous kernel-version the gmac of bpi-r2 can be passed through =
mt7530 switch and gets available external while bypassing dsa core=2E Here =
i wanted renaming of this port (gmac1=3Deth1 mapped as wan-port,while gmac0=
=3Deth0 was splitted by dsa switch driver to lan0-lan3)

>Seems like it could be possible to want to distinguish port types for
>reasons other than just what to name the device=2E Better to describe
>that difference in DT and then base the device name off of that=2E

Interface names should be not only numbering as they can have different me=
aning (wan vs=2E lan)=2E

>If you just want fixed numbering, then 'aliases' node is generally how
>that is done (either because it sneaks in or fatigue from arguing
>fixed /dev nodes are an anti-feature)=2E There's already 'ethernetN'
>which u-boot uses, but the kernel so far does not=2E

Aliases are not yet used as interface name=2E=2E=2Edo you want this way (u=
se alias name as ifname)? imho we can define multiple aliases to one dt nod=
e which is imho not the best way as interface can have only one name, and i=
nterface is created feom target node from where the alias needs to be found=
=2E

regards Frank