Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp48374pxy; Wed, 21 Apr 2021 18:07:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxd9qr9U0krmwwX2uQBZstMgtY/4LOcAgHs+yZocoD/YuAfIvJhNqOYuUleAEuLycMAPz2t X-Received: by 2002:a17:90b:285:: with SMTP id az5mr14214836pjb.0.1619053641486; Wed, 21 Apr 2021 18:07:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619053641; cv=none; d=google.com; s=arc-20160816; b=Wee/L0XW4BUYM8xbnvedwiHn0T2mDTraXyIz13iahIwdZ2vWP1zCnM9oR23EGzkIEg rWwRHxFd4yzMQkmjKGlmcwEgn7AJqB0Mi2sv97w7NmYmt7sIXOUpHY3RHlVBv6a/lwqe kvs8EsPYz0PakkRbnjFdeOsZvFHzLQHj/qeGFVIlJL4w7qP755nU4UuaAXCjlMNwNFO7 Te6gQgPErLJ+LhKalAW1kezz22ziexjZPCalX3HT8JdgdVvtF2A1Mlv8TKw7SFE0ALSR yKx8eX044CYrIimHfBYWo22s9ggK2ZZhFkwSzdKyNDjhTF1oEce+Sk8rhRad5qv7sQaR /ZAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:cc:to:subject:from:message-id; bh=BY3NFBrli2u9GdNxUgzfhqyt7SVBCtwedZLoshxm5gI=; b=MrX2CkjXEmDKWZ9IWEy9WC4w9yUCFzlFSrtBU2AQN6+Azqkjjh8idEuhD0q2TuQKVS HDC2j2SVTACLKoHgI8LcIPS8NvYz5ywZBYyGkChfoeRMzIQfmj9JzTNfWbzcgetzkZYo 9mctBo6lYlwMJUM1qvq7c8JWtHhJDYXyySlvR8cS6Jkj5br9jK+S17EjCuQIF1hPlIyf 3eh+gHkJuSYYbrHH92uqIg1ixp9jKWtyqlzKHdHPIQpzZEemeZVm1ju8EaBI+H5rXxsy CPlNND/iyzdsUKn7QZvbixg05SJVpPnj4m1vOGBjENh7zlJNYxJ4Na/gdtirWja/NWMr /A5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si1259309pgg.313.2021.04.21.18.07.09; Wed, 21 Apr 2021 18:07:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239592AbhDURYn (ORCPT + 99 others); Wed, 21 Apr 2021 13:24:43 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:36275 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239286AbhDURYj (ORCPT ); Wed, 21 Apr 2021 13:24:39 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4FQS8L3R0sz9vBmn; Wed, 21 Apr 2021 19:24:02 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id DNRcKS_Bbf_r; Wed, 21 Apr 2021 19:24:02 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FQS8L2LN7z9vBmm; Wed, 21 Apr 2021 19:24:02 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 025DB8B831; Wed, 21 Apr 2021 19:24:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id JlG_YwR7MWds; Wed, 21 Apr 2021 19:24:03 +0200 (CEST) Received: from po15610vm.idsi0.si.c-s.fr (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id BBA298B82B; Wed, 21 Apr 2021 19:24:03 +0200 (CEST) Received: by po15610vm.idsi0.si.c-s.fr (Postfix, from userid 0) id 7966263955; Wed, 21 Apr 2021 17:24:03 +0000 (UTC) Message-Id: From: Christophe Leroy Subject: [PATCH] powerpc/52xx: Fix an invalid ASM expression ('addi' used instead of 'add') To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Wed, 21 Apr 2021 17:24:03 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org AS arch/powerpc/platforms/52xx/lite5200_sleep.o arch/powerpc/platforms/52xx/lite5200_sleep.S: Assembler messages: arch/powerpc/platforms/52xx/lite5200_sleep.S:184: Warning: invalid register expression In the following code, 'addi' is wrong, has to be 'add' /* local udelay in sram is needed */ udelay: /* r11 - tb_ticks_per_usec, r12 - usecs, overwrites r13 */ mullw r12, r12, r11 mftb r13 /* start */ addi r12, r13, r12 /* end */ Fixes: ee983079ce04 ("[POWERPC] MPC5200 low power mode") Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/52xx/lite5200_sleep.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/52xx/lite5200_sleep.S b/arch/powerpc/platforms/52xx/lite5200_sleep.S index 11475c58ea43..afee8b1515a8 100644 --- a/arch/powerpc/platforms/52xx/lite5200_sleep.S +++ b/arch/powerpc/platforms/52xx/lite5200_sleep.S @@ -181,7 +181,7 @@ sram_code: udelay: /* r11 - tb_ticks_per_usec, r12 - usecs, overwrites r13 */ mullw r12, r12, r11 mftb r13 /* start */ - addi r12, r13, r12 /* end */ + add r12, r13, r12 /* end */ 1: mftb r13 /* current */ cmp cr0, r13, r12 -- 2.25.0