Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp49090pxy; Wed, 21 Apr 2021 18:08:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBNxzLNcK5LHnKDreq5Z/FWTiTDHIR6qfVopv0UlAaZkWaJef2N34bq1zN0y5Zu1Q9grjy X-Received: by 2002:a62:7e41:0:b029:249:287:3706 with SMTP id z62-20020a627e410000b029024902873706mr879194pfc.76.1619053721083; Wed, 21 Apr 2021 18:08:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1619053721; cv=pass; d=google.com; s=arc-20160816; b=wypqHHWcohpSnJ6m43KJh7AX5eMhZfz+jSizASzsZZlWfjGQde11DB42hhSFfXg61w ryZPaJo07ErAMcvdcZzV24t8wbT+29UvP55Uccp+zRAVRjUXSoPnbUMI1ncLOK1Qfy/f 9xoDddPf4BKoXLc/0BmPuxKhxvNZwidy1TjhaUtZYkARoDj6IShoFpMwsw3U4lfmTmXG 7CCw+VuyPVpFmVwKnu11CsTK6nI2thnOu+J4OEJpXTT2CHOpIMsiK8OsiNqrSA8hYpAr 5VDVgrUE7puODyH/Q8Y1kosXmPKrgRIbJzqKvLlPSgGBCOohwG396zeKMG2YyFbJX+fd 2J/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=obrCtbJ+KgZ6tsOyyDAx+m+OwfF0hUYR7eox/my8XBY=; b=m/kOv72fbfCoWd6ILASckQ5/Jxbc4kmgJX51EIGMhIKdp717grxdX3OAEX7L+L65bf 3xZDPrtpAM0azb8TO60Wsim/UwXe+BgRzdj2iUQL6QsQ4n0vTB8JVm9fMfFs+yUQrPmg aRirlSKxP69P36Wp+ies3AGWIO9qn2/dQqS3b0E4Vs3tcxi+Ley2wL6EDlmU1QiSvFSa VisFlH8vPZqRYM0pnzagQjW+kWmOYYweWilQEk4vHM2RD6qWOUKmePkebQQLtUnnh3mi ILZdzXarLOg0y7wydt+eGMSDZY9q+6zXzZpdSVO08BjzvuZ1gJiRAPf2QH+Pngn5Hs9r hnmQ== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=uvos.xyz dmarc=pass fromdomain=uvos.xyz>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h3si1502527pgr.442.2021.04.21.18.08.18; Wed, 21 Apr 2021 18:08:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=uvos.xyz dmarc=pass fromdomain=uvos.xyz>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242798AbhDURfY (ORCPT + 99 others); Wed, 21 Apr 2021 13:35:24 -0400 Received: from sender11-of-o51.zoho.eu ([31.186.226.237]:21113 "EHLO sender11-of-o51.zoho.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239822AbhDURfY (ORCPT ); Wed, 21 Apr 2021 13:35:24 -0400 X-Greylist: delayed 907 seconds by postgrey-1.27 at vger.kernel.org; Wed, 21 Apr 2021 13:35:23 EDT ARC-Seal: i=1; a=rsa-sha256; t=1619025575; cv=none; d=zohomail.eu; s=zohoarc; b=WmXre7ic130ZOYKn+d0nKVKDMIhYzL4dXCULW7ofz24R/FKdC6PdmTZpWJG04hkaGYFT822YkOq2eKN/S+zDe7vZswz2jgyWDPiiNzaO/EPdwtD9jxuN43iOAazDpX4/hIO33rs53rPWEgavBPzK6xEh7tJKsodtk+eLMSeuTOM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1619025575; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=obrCtbJ+KgZ6tsOyyDAx+m+OwfF0hUYR7eox/my8XBY=; b=Tu13UAm6jYWn1VVHyzUV8boM2z5SfT5CZMR/RdOCn6yTaXTd0v8MVQOpMNwQy9wvWRYBlMsRLn1Fu6zd2gBLUjG/UDkSSIqnIMFbcWNJjSlbVAsYi7/ogFaRbyELGDgJHxwugCxmncA3a5bdXOPgUtNGeUn6uxb/fvjAa4QLu8E= ARC-Authentication-Results: i=1; mx.zohomail.eu; spf=pass smtp.mailfrom=philipp@uvos.xyz; dmarc=pass header.from= header.from= Received: from UVOSLinux (ip-95-222-215-74.hsi15.unitymediagroup.de [95.222.215.74]) by mx.zoho.eu with SMTPS id 1619025573833283.36820387667444; Wed, 21 Apr 2021 19:19:33 +0200 (CEST) Date: Wed, 21 Apr 2021 19:19:33 +0200 From: Carl Philipp Klemm To: Tony Lindgren Cc: zhuguangqing83@gmail.com, Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor Message-Id: <20210421191933.6fa083e0b2496aedaef4957a@uvos.xyz> In-Reply-To: References: <20210421143650.16045-1-zhuguangqing83@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good to me, but dosent appear to solve the bootup bug. (this time reply all) Reviewed-by: Carl Philipp Klemm Tested-by: Carl Philipp Klemm -- Carl Philipp Klemm On Wed, 21 Apr 2021 19:04:30 +0300 Tony Lindgren wrote: > Hi, > > * zhuguangqing83@gmail.com [210421 14:38]: > > From: Guangqing Zhu > > > > Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread(). > > Empty list or fully traversed list points to list head, which is not > > NULL (and before the first element containing real data). > > > > Signed-off-by: Guangqing Zhu > > --- > > v2: > > - Modify commit message and code as suggested by Sebastian. > > Thanks looks OK to me. Looks like there's no flag we need to set there when > the entry is found, so this should do for the check. > > Hmm I wonder if this just might fix the issue where booting with a USB > charger connected can hang.. > > Reviewed-by: Tony Lindgren > > > --- > > drivers/power/supply/cpcap-battery.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c > > index 6d5bcdb9f45d..a3fc0084cda0 100644 > > --- a/drivers/power/supply/cpcap-battery.c > > +++ b/drivers/power/supply/cpcap-battery.c > > @@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data) > > break; > > } > > > > - if (!d) > > + if (list_entry_is_head(d, &ddata->irq_list, node)) > > return IRQ_NONE; > > > > latest = cpcap_battery_latest(ddata); > > -- > > 2.17.1 > >