Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp51094pxy; Wed, 21 Apr 2021 18:12:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmaKhLCz1lZectcQ1xssZl2MJ7i0IyQR9WwJR+VZay8cKjfgB/OTT8e2qxLABcfUmn7TLF X-Received: by 2002:aa7:84c8:0:b029:261:d799:e7a with SMTP id x8-20020aa784c80000b0290261d7990e7amr882369pfn.68.1619053929521; Wed, 21 Apr 2021 18:12:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619053929; cv=none; d=google.com; s=arc-20160816; b=LC2HW4zAFGfr0MjNuI8I4T6IlOdSqwWalAeCW3WwwtDk78qk/3TaAWa8+rJfuyeVpo Vh2fCrimRtZqO4b7h1EaLLWjAwPT4ZvIUK8pr8aHfiN0pdPsePNM/LTxhMYWQ/JsZD0K u6ntY+4zPG7iXOMU2N4oq3PK8LwEolUOE28jg2tNg57SYTws5Tr+zHGUxcBLEyizRpxF AexVlLirK9YIMS3k+7qJsdTg4Ct2OTBoqKafsnDQVBaoTSiEnOUhrCu8TuKcZYi6W8oe pi+DCGGshDPsDsv0vs3IqjL/W7IFyDgtjcSrelX1TI4/coqJ5u7iBMBfhw3lIgLChFIE EcQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vA2zz6fdzoEIc7sQXfbEwVahvXg9jSWxjWkyLFPSiEM=; b=QJp6PXlaeGuD7e8TVUqS1dgbd6bU2wBcAXB6XY3amC4jrtOvmqf9L3Xd/5ePKMy0EL YJYUvIXQxo6h7thP9Yh+Z/eTxO2tjKmG52YX5PKZ4oUUIWrGxnqh1+eBxxI6uwt5qHSP iLmB0NMuU0kSI987fMTRsaR2nv7ZTaOeifKfD9jgWTVwIYPHFvu1IB2oydQAloGsLbvc X2BZiAY/fjbJtbKg5t7wAdTVCvDFOAywOXMojpv+9PeO4d01UKpbPm6bSKljFT6Krul1 rtomuMqo24mDVOsKtwHVSTehz/VM3pt5mah7Ft+rZp5pqL93D1v9+6YSSl+a1gbwxqMz 20mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K+zuczsW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p11si1259032pfn.246.2021.04.21.18.11.40; Wed, 21 Apr 2021 18:12:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K+zuczsW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244872AbhDURr3 (ORCPT + 99 others); Wed, 21 Apr 2021 13:47:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:58974 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243381AbhDURr3 (ORCPT ); Wed, 21 Apr 2021 13:47:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5776C6113B; Wed, 21 Apr 2021 17:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619027215; bh=a6WRC3swuMxcN5gibDf6fwqEFFmXnQfRYNe6DYYDHGg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K+zuczsW81yOc1sT0GCZabu+dTVGED9HH1O1aB3buMu8rY5as57wDTRXsiRonMCCh 8F+JJjt4cCF1j1e1YzoASdZcDJsSJMgj7XnpT1D8nMxk3h3zNJce+tetMUaWXgcxjk J3T/3koZ+c7vtbf4l2R/j4CevgT3OE1WlI5c7sMgj9s1okKI5W6aZtd10bsRHZydPD HAPDpsVceaH0BpI1owE971oufN4iERFqMDQwMG6J/wAhtEakNx6Qu+NF5BPBjcb3D7 gg7xbksiDqgJKOGPh5yNSr8vz8CGj7mKQQABCntxKprI8QU6BP4mDF6rZ/7T8Q4vIB ysmQ0vqikyOKA== Date: Wed, 21 Apr 2021 18:46:29 +0100 From: Mark Brown To: Lucas Stach Cc: Robin Gong , Shengjiu Wang , Nicolin Chen , Linux-ALSA , Liam Girdwood , "s.hauer@pengutronix.de" , Timur Tabi , Xiubo Li , "shawnguo@kernel.org" , "S.j. Wang" , linux-kernel , "dri-devel@lists.freedesktop.org" , Takashi Iwai , "linaro-mm-sig@lists.linaro.org" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "perex@perex.cz" , "linuxppc-dev@lists.ozlabs.org" , "sumit.semwal@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Subject: Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe Message-ID: <20210421174629.GD4617@sirena.org.uk> References: <53258cd99caaf1199036737f8fad6cc097939567.camel@pengutronix.de> <50ef17a2d57b022c48bbca71fd4e074cc3ca9be5.camel@pengutronix.de> <97262466d537402ad4032098ef277d6d47734f1f.camel@pengutronix.de> <18fbdc4bf0574a722134400ad9e4510d3cbcb767.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sgneBHv3152wZ8jf" Content-Disposition: inline In-Reply-To: <18fbdc4bf0574a722134400ad9e4510d3cbcb767.camel@pengutronix.de> X-Cookie: RELATIVES!! User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sgneBHv3152wZ8jf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 21, 2021 at 07:43:18PM +0200, Lucas Stach wrote: > If your driver code drops the rpm refcount to 0 and starts the > autosuspend timer while a cyclic transfer is still in flight this is > clearly a bug. Autosuspend is not there to paper over driver bugs, but > to amortize cost of actually suspending and resuming the hardware. Your > driver code must still work even if the timeout is 0, i.e. the hardware > is immediately suspended after you drop the rpm refcount to 0. > If you still have transfers queued/in-flight the driver code must keep > a rpm reference. Right, failing to do that is a clear bug. Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrolling through the irrelevant quoted material. --sgneBHv3152wZ8jf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCAZPQACgkQJNaLcl1U h9CQHwf/aovjO8Ad2u7sCq5MwvRFCIYwJ1CpKRnX4pLM6wYJq/w0MMfWMFZsAxb9 9S1OpyvCFbGe76zbcqhKj8S21KBhXizZkfD6Vpe7TFugCGPJCjB51bMfLr2pGBBI lDbi5cFUapnWSp38AOK4/JEVOP/dQKJgt3ndadidkyLPtTUBqpEYMhiZ8EymPB8z YTmINg9bemV7OpbuzDCytmQIGSf/UPGYu09wfS5uLHUS2qdVPdc+uWqUe+RgsZqT 88ZMLGQBZMRhTcdn4UVONaM3WNTv7hi1Xh/3B+3NlViFFrbhk7RQ9HGjNDrEKQ0C P2NTaTgDl0M0cEWTDLH8M/aAJzaCqg== =XMAS -----END PGP SIGNATURE----- --sgneBHv3152wZ8jf--