Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: uCCXmVgpPRXiUFehm+aeZWawIS+MNKChXNXFxnGke9QzkSn1makgDophfRyaGDJDbwfYeMnr3m
 TlT6CjGVqx3g==
IronPort-SDR: G89qDqo2oHdvPA03l8fUHO7SiY2xJCah0aGHRtlGk9HU+B1ZW8qYKJBfNM+WKZwrM+F61wmSQM
 QwcnZD6yHYvA==
Subject: Re: [PATCH 041/190] Revert "ACPI: sysfs: Fix reference count leak in
 acpi_sysfs_add_hotplug_profile()"
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc:     Qiushi Wu <wu000273@umn.edu>, "3 . 10+" <stable@vger.kernel.org>
References: <20210421130105.1226686-1-gregkh@linuxfoundation.org>
 <20210421130105.1226686-42-gregkh@linuxfoundation.org>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
Message-ID: <c7451c62-69fe-bd8f-f90c-5574cf70b60c@intel.com>
Date:   Wed, 21 Apr 2021 19:54:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <20210421130105.1226686-42-gregkh@linuxfoundation.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 4/21/2021 2:58 PM, Greg Kroah-Hartman wrote:
> This reverts commit 6e6c25283dff866308c87b49434c7dbad4774cc0.
>
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
>
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
>
> Cc: Qiushi Wu <wu000273@umn.edu>
> Cc: 3.10+ <stable@vger.kernel.org> # 3.10+
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>


> ---
>   drivers/acpi/sysfs.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
> index 8baf7644a0d0..842bf63b91e9 100644
> --- a/drivers/acpi/sysfs.c
> +++ b/drivers/acpi/sysfs.c
> @@ -986,10 +986,8 @@ void acpi_sysfs_add_hotplug_profile(struct acpi_hotplug_profile *hotplug,
>   
>   	error = kobject_init_and_add(&hotplug->kobj,
>   		&acpi_hotplug_profile_ktype, hotplug_kobj, "%s", name);
> -	if (error) {
> -		kobject_put(&hotplug->kobj);
> +	if (error)
>   		goto err_out;
> -	}
>   
>   	kobject_uevent(&hotplug->kobj, KOBJ_ADD);
>   	return;