Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp53508pxy; Wed, 21 Apr 2021 18:16:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy05kaiDx0k456D6Eqr9onVd4B0DspvHMsfQo3UPYpY7k1hwgUdbZQWDHbQsZysAzSkq2m4 X-Received: by 2002:a17:903:1ce:b029:ec:b44d:7c4d with SMTP id e14-20020a17090301ceb02900ecb44d7c4dmr829536plh.36.1619054196401; Wed, 21 Apr 2021 18:16:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619054196; cv=none; d=google.com; s=arc-20160816; b=EqColGf9C2egFAE+wsYgAnash12O9gA0aCBURP4Z57ZG8DMps/kzjPjYX/dWJkHo7Q watnl11Ysp7DLcN/7YBu4in5bYBgHnaF/cuigTuSiKIpm+KXQr7izTjaSNxyzweUYtDr j+0VSFoeMFvoXqLZdFLBO6u33PNtg+HE60+Y8sxk4LGaZ+I29gdFLppH8o3Qa4TLFlMp 8PgOnRa4UKkBwCVg/0FiOhyGGcvNfozAPkKEx5l/T80W5Xrs4FGsu13jobrWLS0W2TDR 7diH6OBxAtnR9G9pK7ZM5e+e2CAB8MKwGcpBUQTqqdAFnq5u+F8D3FEzdPzwI3uLpvKO TVOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=RIGc+OeRdpEGx0bF6hvq9LRaC7nR84RdaLqY5gQak1c=; b=FFjWCBdXQ4OO7IfVz/kTJ+DejXBCgFPOWM4Yo2T8DtsGoLgoUNuOyjvJaMRjaFdvB+ wjXOV0S6zE6RlPQq/bNKiKkmv6zyjjNbfpBvA/tF6qUSQ9sY3HuKsiv33TJ9MaxiUFE4 pADAa6d9pVWKp5P0YYiZhTTRzgOypY/c4ynLlZ0DFnpNibZE9RNKiuId93yM41VSt5bb y0vmGQbUIYDUTPodP5lIXz3TEesWKj8QzWAl42A7XRjJVuvEa5fG1Rr7mHFzAOs8qLIc 2tm5vefRCx0DNN05I3hYMX7S7dIlvH07iDZucpTsypKMgJ7T+azyu9Bhuf4KyMkdycOr V90w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i5jVbfxv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z22si1222093pgf.543.2021.04.21.18.16.24; Wed, 21 Apr 2021 18:16:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i5jVbfxv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244154AbhDUSKn (ORCPT + 99 others); Wed, 21 Apr 2021 14:10:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:43728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240952AbhDUSKn (ORCPT ); Wed, 21 Apr 2021 14:10:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id 2CD1761435; Wed, 21 Apr 2021 18:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619028609; bh=USuuWsJ1gBE2x6CH0iH7AojvNEEpAjyMSraWW8nP1Cg=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=i5jVbfxvE0cgSeBZ+kRP1A+f8FeK6TCK/opVMxRbRcTZp2C4MHDTjPgaQB+nT7HGZ OriyWjNOT9WJxosysMZqAMZRqAG+e/MJkYAd7D1aYAnduPX+9D+x2FlupSC/fGOLNV Wd/2SUAIwBI/2xT5BRLWNy0DVtClHI09O88lT6x/Cyrjbepi52o2Ia1PNPnZo8PMJv Q3poC7SOFGNspQrTC80NxFlICKIxkBqc4QtPOA+AuD6D+d5aslD09bkVjPYk5IkY4Q fTGg55F/yCi/mM9HbH0w4qBerdBOuc/DFzLM1oj3d3BCHpPfx/EAdK0hILoFeJD7CW a4e0azbPT6VUw== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 23EB7609AD; Wed, 21 Apr 2021 18:10:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: qrtr: Avoid potential use after free in MHI send From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161902860914.28303.4568064883705440314.git-patchwork-notify@kernel.org> Date: Wed, 21 Apr 2021 18:10:09 +0000 References: <20210421174007.2954194-1-bjorn.andersson@linaro.org> In-Reply-To: <20210421174007.2954194-1-bjorn.andersson@linaro.org> To: Bjorn Andersson Cc: mani@kernel.org, davem@davemloft.net, kuba@kernel.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 21 Apr 2021 10:40:07 -0700 you wrote: > It is possible that the MHI ul_callback will be invoked immediately > following the queueing of the skb for transmission, leading to the > callback decrementing the refcount of the associated sk and freeing the > skb. > > As such the dereference of skb and the increment of the sk refcount must > happen before the skb is queued, to avoid the skb to be used after free > and potentially the sk to drop its last refcount.. > > [...] Here is the summary with links: - net: qrtr: Avoid potential use after free in MHI send https://git.kernel.org/netdev/net/c/47a017f33943 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html