Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Apr 2021 17:03:02 -0500
From:   Rob Herring <robh@kernel.org>
To:     Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        John Crispin <john@phrozen.org>
Subject: Re: [PATCH] dt-bindings: net: mediatek/ralink: remove unused bindings
Message-ID: <20210421220302.GA1637795@robh.at.kernel.org>
References: <20210420024222.101615-1-ilya.lipnitskiy@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210420024222.101615-1-ilya.lipnitskiy@gmail.com>
Precedence: bulk

On Mon, Apr 19, 2021 at 07:42:22PM -0700, Ilya Lipnitskiy wrote:
> Revert commit 663148e48a66 ("Documentation: DT: net: add docs for
> ralink/mediatek SoC ethernet binding")
> 
> No in-tree drivers use the compatible strings present in these bindings,
> and some have been superseded by DSA-capable mtk_eth_soc driver, so
> remove these obsolete bindings.

Looks like maybe OpenWRT folks are using these. If so, you can't revert 
them.

> 
> Cc: John Crispin <john@phrozen.org>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> ---
>  .../bindings/net/mediatek,mt7620-gsw.txt      | 24 --------
>  .../bindings/net/ralink,rt2880-net.txt        | 59 -------------------
>  .../bindings/net/ralink,rt3050-esw.txt        | 30 ----------
>  3 files changed, 113 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt
>  delete mode 100644 Documentation/devicetree/bindings/net/ralink,rt2880-net.txt
>  delete mode 100644 Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt b/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt
> deleted file mode 100644
> index 358fed2fab43..000000000000
> --- a/Documentation/devicetree/bindings/net/mediatek,mt7620-gsw.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -Mediatek Gigabit Switch
> -=======================
> -
> -The mediatek gigabit switch can be found on Mediatek SoCs (mt7620, mt7621).
> -
> -Required properties:
> -- compatible: Should be "mediatek,mt7620-gsw" or "mediatek,mt7621-gsw"
> -- reg: Address and length of the register set for the device
> -- interrupts: Should contain the gigabit switches interrupt
> -- resets: Should contain the gigabit switches resets
> -- reset-names: Should contain the reset names "gsw"
> -
> -Example:
> -
> -gsw@10110000 {
> -	compatible = "ralink,mt7620-gsw";
> -	reg = <0x10110000 8000>;
> -
> -	resets = <&rstctrl 23>;
> -	reset-names = "gsw";
> -
> -	interrupt-parent = <&intc>;
> -	interrupts = <17>;
> -};
> diff --git a/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt b/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt
> deleted file mode 100644
> index 9fe1a0a22e44..000000000000
> --- a/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt
> +++ /dev/null
> @@ -1,59 +0,0 @@
> -Ralink Frame Engine Ethernet controller
> -=======================================
> -
> -The Ralink frame engine ethernet controller can be found on Ralink and
> -Mediatek SoCs (RT288x, RT3x5x, RT366x, RT388x, rt5350, mt7620, mt7621, mt76x8).
> -
> -Depending on the SoC, there is a number of ports connected to the CPU port
> -directly and/or via a (gigabit-)switch.
> -
> -* Ethernet controller node
> -
> -Required properties:
> -- compatible: Should be one of "ralink,rt2880-eth", "ralink,rt3050-eth",
> -  "ralink,rt3050-eth", "ralink,rt3883-eth", "ralink,rt5350-eth",
> -  "mediatek,mt7620-eth", "mediatek,mt7621-eth"
> -- reg: Address and length of the register set for the device
> -- interrupts: Should contain the frame engines interrupt
> -- resets: Should contain the frame engines resets
> -- reset-names: Should contain the reset names "fe". If a switch is present
> -  "esw" is also required.
> -
> -
> -* Ethernet port node
> -
> -Required properties:
> -- compatible: Should be "ralink,eth-port"
> -- reg: The number of the physical port
> -- phy-handle: reference to the node describing the phy
> -
> -Example:
> -
> -mdio-bus {
> -	...
> -	phy0: ethernet-phy@0 {
> -		phy-mode = "mii";
> -		reg = <0>;
> -	};
> -};
> -
> -ethernet@400000 {
> -	compatible = "ralink,rt2880-eth";
> -	reg = <0x00400000 10000>;
> -
> -	#address-cells = <1>;
> -	#size-cells = <0>;
> -
> -	resets = <&rstctrl 18>;
> -	reset-names = "fe";
> -
> -	interrupt-parent = <&cpuintc>;
> -	interrupts = <5>;
> -
> -	port@0 {
> -		compatible = "ralink,eth-port";
> -		reg = <0>;
> -		phy-handle = <&phy0>;
> -	};
> -
> -};
> diff --git a/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt b/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt
> deleted file mode 100644
> index 87e315856efa..000000000000
> --- a/Documentation/devicetree/bindings/net/ralink,rt3050-esw.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -Ralink Fast Ethernet Embedded Switch
> -====================================
> -
> -The ralink fast ethernet embedded switch can be found on Ralink and Mediatek
> -SoCs (RT3x5x, RT5350, MT76x8).
> -
> -Required properties:
> -- compatible: Should be "ralink,rt3050-esw"
> -- reg: Address and length of the register set for the device
> -- interrupts: Should contain the embedded switches interrupt
> -- resets: Should contain the embedded switches resets
> -- reset-names: Should contain the reset names "esw"
> -
> -Optional properties:
> -- ralink,portmap: can be used to choose if the default switch setup is
> -  llllw or wllll
> -- ralink,led_polarity: override the active high/low settings of the leds
> -
> -Example:
> -
> -esw@10110000 {
> -	compatible = "ralink,rt3050-esw";
> -	reg = <0x10110000 8000>;
> -
> -	resets = <&rstctrl 23>;
> -	reset-names = "esw";
> -
> -	interrupt-parent = <&intc>;
> -	interrupts = <17>;
> -};
> -- 
> 2.31.1
>