Date: Wed, 18 Oct 2006 10:38:10 -0400
From: Chris Mason <chris.mason@oracle.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>, Josef Sipek <jsipek@fsl.cs.sunysb.edu>,
       linux-kernel@vger.kernel.org, hch@infradead.org, mhalcrow@us.ibm.com,
       penberg@cs.helsinki.fi, linux-fsdevel@vger.kernel.org
Subject: Re: fsstack: struct path
Message-ID: <20061018143810.GB16570@think.oraclecorp.com>
References: <20061018042323.GA8537@filer.fsl.cs.sunysb.edu> <20061018013103.4ad6311a.akpm@osdl.org> <20061018083527.GJ29920@ftp.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061018083527.GJ29920@ftp.linux.org.uk>
User-Agent: Mutt/1.5.12-2006-07-14
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1231
Lines: 30

On Wed, Oct 18, 2006 at 09:35:27AM +0100, Al Viro wrote:
> On Wed, Oct 18, 2006 at 01:31:03AM -0700, Andrew Morton wrote:
> > > One, rather unfortunate, fact is that struct path is also defined in
> > > include/linux/reiserfs_fs.h as something completely different - reiserfs
> > > specific.
> > > 
> > > Any thoughts?
> > > 
> > 
> > reiserfs is being bad.  s/path/reiserfs_path/g
> 
> Indeed.  That's one pending patch that never got around to be submitted
> (and had bitrotten at least 3 times, IIRC).
> 
> ACK, provided that reiserfs folks are OK with the replacement name for
> their struct.  Note that "path" in question has very little to do with
> pathnames - it's a path in balanced tree, IIRC.  So if we get around
> to renaming that sucker, it might be a good time to pick better name.

Aside from having to reindent the reiserfs tree afterwards, I doubt
anyone would mind (please cc reiserfs-dev on the patch though).  Al is
right, it's a path in the balanced tree.

-chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/