Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Nxk6rqJcb7PUioFo0/usAp2hnew/lxj9/Ruoej77wLXehvbvUpZZlZTIKzALUJUCWq2AEfObPh
 ozVhBx9LAWDA==
IronPort-SDR: fUPT+MPQOVG0IKK0A+jG6q2HwBfctbodIzmZWE9HHhnq1ufrWWa7KvfFpuFyHrUbARVZtaC4OZ
 jVcwM3XKa3lA==
Subject: Re: [PATCH v4 24/25] perf tests: Support 'Convert perf time to TSC'
 test for hybrid
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
References: <20210416140517.18206-1-yao.jin@linux.intel.com>
 <20210416140517.18206-25-yao.jin@linux.intel.com> <YIBu/DyPmMf1Mta4@krava>
From:   "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <fd34b4fb-817b-0cf5-f8ce-7d860748e9a6@linux.intel.com>
Date:   Thu, 22 Apr 2021 11:16:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <YIBu/DyPmMf1Mta4@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jiri,

On 4/22/2021 2:29 AM, Jiri Olsa wrote:
> On Fri, Apr 16, 2021 at 10:05:16PM +0800, Jin Yao wrote:
>> Since for "cycles:u' on hybrid platform, it creates two "cycles".
>> So the second evsel in evlist also needs initialization.
>>
>> With this patch,
>>
>>    # ./perf test 71
>>    71: Convert perf time to TSC                                        : Ok
>>
>> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
>> ---
>>   tools/perf/tests/perf-time-to-tsc.c | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/tools/perf/tests/perf-time-to-tsc.c b/tools/perf/tests/perf-time-to-tsc.c
>> index 680c3cffb128..72f268c6cc5d 100644
>> --- a/tools/perf/tests/perf-time-to-tsc.c
>> +++ b/tools/perf/tests/perf-time-to-tsc.c
>> @@ -20,6 +20,7 @@
>>   #include "tsc.h"
>>   #include "mmap.h"
>>   #include "tests.h"
>> +#include "pmu.h"
>>   
>>   #define CHECK__(x) {				\
>>   	while ((x) < 0) {			\
>> @@ -66,6 +67,10 @@ int test__perf_time_to_tsc(struct test *test __maybe_unused, int subtest __maybe
>>   	u64 test_tsc, comm1_tsc, comm2_tsc;
>>   	u64 test_time, comm1_time = 0, comm2_time = 0;
>>   	struct mmap *md;
>> +	bool hybrid = false;
>> +
>> +	if (perf_pmu__has_hybrid())
>> +		hybrid = true;
>>   
>>   	threads = thread_map__new(-1, getpid(), UINT_MAX);
>>   	CHECK_NOT_NULL__(threads);
>> @@ -88,6 +93,17 @@ int test__perf_time_to_tsc(struct test *test __maybe_unused, int subtest __maybe
>>   	evsel->core.attr.disabled = 1;
>>   	evsel->core.attr.enable_on_exec = 0;
>>   
>> +	/*
>> +	 * For hybrid "cycles:u", it creates two events.
>> +	 * Init the second evsel here.
>> +	 */
>> +	if (hybrid) {
> 
> same, don't see the reason for 'hybrid' variable
> 

OK, will use 'if (perf_pmu__has_hybrid())' instead.

Thanks
Jin Yao

> jirka
> 
>> +		evsel = evsel__next(evsel);
>> +		evsel->core.attr.comm = 1;
>> +		evsel->core.attr.disabled = 1;
>> +		evsel->core.attr.enable_on_exec = 0;
>> +	}
>> +
>>   	CHECK__(evlist__open(evlist));
>>   
>>   	CHECK__(evlist__mmap(evlist, UINT_MAX));
>> -- 
>> 2.17.1
>>
>