Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: USrXF+lAYRUtp5dShKqyJCi+tQJWA++Ccie0HquRqJEbas72sUjFApfv4HQA7Kn7loGmRRyXdA
 6SNY3n4HJii0ZQODRtIp4oJKDTCM3RL722CxrXKtqjgI8ewGxNujRAWIaUkT92Y2lxFBeQXQO6
 eRhY2JlCD3JN4c+KuhLVEins+6WAi3wp9E4GtGFCROC7N7siAu+rLYC02xc9ZTis2syI1gp1BE
 HYCp0rgx+51NOFZGH20GW6Yj7yCHE8vM4u1ASMeJCQNPjNMcnbUaCY+45traAji1Tzau2ZNrIa
 cEQ=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Oliver Sang <oliver.sang@intel.com>
CC:     Jens Axboe <axboe@kernel.dk>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>,
        "lkp@intel.com" <lkp@intel.com>, Beibei Si <beibei.si@intel.com>,
        Omar Sandoval <osandov@osandov.com>
Subject: Re: [null_blk] de3510e52b: blktests.block.014.fail
Thread-Topic: [null_blk] de3510e52b: blktests.block.014.fail
Thread-Index: AQHXK6mdYy0b2r7TZEO50jg8+Qg5bg==
Date:   Thu, 22 Apr 2021 04:08:09 +0000
Message-ID: <BL0PR04MB6514B70E428937AD90679F3EE7469@BL0PR04MB6514.namprd04.prod.outlook.com>
References: <20210407085942.GF22260@xsang-OptiPlex-9020>
 <BL0PR04MB651491ED14D710890187B3D1E7759@BL0PR04MB6514.namprd04.prod.outlook.com>
 <20210422032959.GA31382@xsang-OptiPlex-9020>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a109128-3885-4d48-d19b-08d905443dba
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2021 04:08:09.9910
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WsKuS+WMcYs5iQXwBb/aT6heZOyYNu8yRoPrDL6ouycQib/YnpPn41153sJEJ0mqAOc0fd96Gi8Nu+ZqH8Ea4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR04MB4980
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021/04/22 12:12, Oliver Sang wrote:=0A=
> hi, Damien Le Moal,=0A=
> =0A=
> On Wed, Apr 07, 2021 at 12:29:11PM +0000, Damien Le Moal wrote:=0A=
>> On 2021/04/07 18:02, kernel test robot wrote:=0A=
>>>=0A=
>>>=0A=
>>> Greeting,=0A=
>>>=0A=
>>> FYI, we noticed the following commit (built with gcc-9):=0A=
>>>=0A=
>>> commit: de3510e52b0a398261271455562458003b8eea62 ("null_blk: fix comman=
d timeout completion handling")=0A=
>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master=
=0A=
>>>=0A=
>>>=0A=
>>> in testcase: blktests=0A=
>>> version: blktests-x86_64-a210761-1_20210124=0A=
>>> with following parameters:=0A=
>>>=0A=
>>> 	disk: 1SSD=0A=
>>> 	test: nvme-group-00=0A=
>>> 	ucode: 0x11=0A=
>>>=0A=
>>>=0A=
>>>=0A=
>>> on test machine: 288 threads Intel(R) Xeon Phi(TM) CPU 7295 @ 1.50GHz w=
ith 80G memory=0A=
>>>=0A=
>>> caused below changes (please refer to attached dmesg/kmsg for entire lo=
g/backtrace):=0A=
>>>=0A=
>>>=0A=
>>>=0A=
>>> If you fix the issue, kindly add following tag=0A=
>>> Reported-by: kernel test robot <oliver.sang@intel.com>=0A=
>>>=0A=
>>>=0A=
>>> block/014 (run null-blk with blk-mq and timeout injection configured)=
=0A=
>>> block/014 (run null-blk with blk-mq and timeout injection configured) [=
failed]=0A=
>>>     runtime  ...  71.624s=0A=
>>>     --- tests/block/014.out     2021-01-24 06:04:08.000000000 +0000=0A=
>>>     +++ /mnt/nvme-group-00/nodev/block/014.out.bad      2021-04-06 09:2=
1:25.133971868 +0000=0A=
>>>     @@ -1,2 +1,377 @@=0A=
>>>      Running block/014=0A=
>>>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>>>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>>>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>>>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>>>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>>>     +dd: error reading '/dev/nullb0': Connection timed out=0A=
>>>     ...=0A=
>>>     (Run 'diff -u tests/block/014.out /mnt/nvme-group-00/nodev/block/01=
4.out.bad' to see the entire diff)=0A=
>>=0A=
>> This is not a kernel bug. It is a problem with blktest. Before my patch,=
 the=0A=
>> timeout error was not propagated back to the user. It is now and causes =
dd to=0A=
>> fail. blktest seeing dd failing reports the test as failed. On the kerne=
l side,=0A=
>> all is good, the reqs are completed as expected.=0A=
>>=0A=
>> Note that the timeout error is reported back as is, using BLK_STS_TIMEOU=
T which=0A=
>> becomes ETIMEDOUT, hence the "Connection timed out" error message. May b=
e we=0A=
>> should use the more traditional EIO ? Jens ?=0A=
>>=0A=
>> In any case, I will send a patch to fix blktest block/014.=0A=
> =0A=
> Thanks for information!=0A=
> we checked the latest blktest repo (https://github.com/osandov/blktests)=
=0A=
> but didn't find the fix. did we miss something?=0A=
> =0A=
> when patch upstreamed, we could retest and confirm the fix. Thanks=0A=
=0A=
I posted the patch:=0A=
=0A=
https://www.spinics.net/lists/linux-block/msg66855.html=0A=
=0A=
But I have not received any feedback from Omar yet (added on CC)=0A=
=0A=
=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=