Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 22 Apr 2021 10:13:29 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc:     linux-kernel@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH 002/190] Revert "media: st-delta: Fix reference count
 leak in delta_run_work"
Message-ID: <YIEwKeINI8VOG+S4@kroah.com>
References: <20210421130105.1226686-1-gregkh@linuxfoundation.org>
 <20210421130105.1226686-3-gregkh@linuxfoundation.org>
 <b6e00864-f28a-ee9a-ea53-d1a8aa8c42fb@xs4all.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b6e00864-f28a-ee9a-ea53-d1a8aa8c42fb@xs4all.nl>
Precedence: bulk

On Thu, Apr 22, 2021 at 10:02:32AM +0200, Hans Verkuil wrote:
> Hi Greg,
> 
> I re-reviewed all the patches in this series where I was CCed.
> 
> These are all good and fix real bugs and should be re-reverted:
> 
> [PATCH 002/190] Revert "media: st-delta: Fix reference count leak in delta_run_work"
> [PATCH 003/190] Revert "media: sti: Fix reference count leaks"
> [PATCH 004/190] Revert "media: exynos4-is: Fix several reference count leaks due to pm_runtime_get_sync"
> [PATCH 005/190] Revert "media: exynos4-is: Fix a reference count leak due to pm_runtime_get_sync"
> [PATCH 006/190] Revert "media: exynos4-is: Fix a reference count leak"
> [PATCH 008/190] Revert "media: stm32-dcmi: Fix a reference count leak"
> [PATCH 009/190] Revert "media: s5p-mfc: Fix a reference count leak"
> [PATCH 010/190] Revert "media: camss: Fix a reference count leak."
> [PATCH 011/190] Revert "media: platform: fcp: Fix a reference count leak."
> [PATCH 012/190] Revert "media: rockchip/rga: Fix a reference count leak."
> [PATCH 013/190] Revert "media: rcar-vin: Fix a reference count leak."
> [PATCH 014/190] Revert "media: rcar-vin: Fix a reference count leak."
> [PATCH 052/190] Revert "media: media/saa7146: fix incorrect assertion in saa7146_buffer_finish"
> [PATCH 056/190] Revert "media: davinci/vpfe_capture.c: Avoid BUG_ON for register failure"
> [PATCH 057/190] Revert "media: saa7146: Avoid using BUG_ON as an assertion"
> [PATCH 058/190] Revert "media: cx231xx: replace BUG_ON with recovery code"
> [PATCH 102/190] Revert "media: video-mux: fix null pointer dereferences"
> [PATCH 183/190] Revert "media: isif: fix a NULL pointer dereference bug"
> 
> This one can be dropped since it actually contains a bug, I'm fairly certain
> that was unintentional:
> 
> [PATCH 007/190] Revert "media: ti-vpe: Fix a missing check and reference count leak"
> 
> I'll reply to that one separately.
> 
> This one can be dropped since it is not necessary:
> 
> [PATCH 073/190] Revert "media: rcar_drif: fix a memory disclosure"
> 
> The V4L2 core already zeroes this. Other drivers that use fmt.sdr also
> memset this, but that should be dropped in those drivers as well. I'll
> make a patch for that.

Wonderful, many thanks for doing this review, I'll be dropping these
from the series.

greg k-h