Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161178AbWJRPxB (ORCPT ); Wed, 18 Oct 2006 11:53:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161194AbWJRPxA (ORCPT ); Wed, 18 Oct 2006 11:53:00 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:51214 "HELO iolanthe.rowland.org") by vger.kernel.org with SMTP id S1161178AbWJRPw7 (ORCPT ); Wed, 18 Oct 2006 11:52:59 -0400 Date: Wed, 18 Oct 2006 11:52:57 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Matthew Wilcox cc: Brian King , Alan Cox , , , , Adam Belay Subject: Re: [linux-pm] [PATCH] Block on access to temporarily unavailable pci device In-Reply-To: <20061018145141.GO22289@parisc-linux.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 904 Lines: 23 On Wed, 18 Oct 2006, Matthew Wilcox wrote: > On Wed, Oct 18, 2006 at 10:38:20AM -0400, Alan Stern wrote: > > You have to do _something_, because a user task could be about to read the > > configuration space at the exact moment you want to start the BIST. That > > means ipr would have to wait until the user access is finished, which > > means it has to be prepared to sleep one way or another. > > Actually, it only has to spin until the user has finished accessing > config space. See the patch I just posted. I stand corrected. Don't you want the user process to wait in TASK_INTERRUPTIBLE? It would require only a very simple change. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/