Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp279697pxy; Thu, 22 Apr 2021 01:50:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyE3qDdIXA9LA/iCgeXHnnkAah5DPToRtRRIPZcqurnRUW30aZm5oWH7z+Vw0Au8aycZPtw X-Received: by 2002:a17:906:3111:: with SMTP id 17mr2171673ejx.403.1619081440584; Thu, 22 Apr 2021 01:50:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619081440; cv=none; d=google.com; s=arc-20160816; b=P0PGzoPEkDmOsorW5XX7Q6WSYvSOLbLsifbM2Z5fmNmVLUELGL6olLjhuifGt5vdqo CrlhdSv5aw2wJfiRfiHdXMY97zg6dwNlVGczTShkGF6eTfRVgHMlzQedlEn/DuBak5Vr BdRrntTj5S+27sIHvvexe/xb2zHkeEnGYY2GlNkfXHuD/vrBWKADKLcx73K3b6YQbRYQ 9/ykDdwAD7vlS6qOrK9SaMopbahWt5Rs6sHNSetP5QiRi7PsNbnI4XQmMnzTin5aCAOH t8Nm8yEE0v5xNiIxoTJ45A2OA1RzF8dQkkDEsR+bzRTRFXJd1IE9BE0XdT2c4CMYliiF Z/1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/LEk7vDGRMBFQuG1ktTPTWOZ+UhItZujTScjVhJoAzY=; b=zl3gtJVmqXC8KIivN76J0rrpO5NrzwHK8TW9JdrDQZwOUdplxldQ4E5nQAOoW1HXwR LUehxxdA4VSOZuck5PXXnYmQ0+6iPW+FFnZ+uoDGBgdHRzGp6fDCX0MYsYpnDp38bnaG n18grlz87hkw3QvDU/1fvuZpbhDlM4L+nv7BLyOQfQPvlktQd3xBss/VcFT8OvD7vc0e AGUZMLqB1e/g4sg7p+231tad6SScKV0FeJhvmRB6I2sVYMQDiSU6H6hWp9q/T6xcIVva PtW3+QARa5zJXQ3dEy/GWhG/1X4DUwT0wzxvhWD03BzjR/YsO5b9g2Ksik3V1L523+ll 3IrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SVXhbX4L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t8si1717973ejy.77.2021.04.22.01.50.17; Thu, 22 Apr 2021 01:50:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SVXhbX4L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235639AbhDVItt (ORCPT + 99 others); Thu, 22 Apr 2021 04:49:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:34708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235637AbhDVIts (ORCPT ); Thu, 22 Apr 2021 04:49:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BE444613ED; Thu, 22 Apr 2021 08:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619081353; bh=/LEk7vDGRMBFQuG1ktTPTWOZ+UhItZujTScjVhJoAzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SVXhbX4L8aaIeJscLyBH7GL2fiWNLQlXdU3daA5puPJC3YfMDINeekOuuxx70N5mv HtgxKeXQcb4zcYi529Q0s8lie1pVj26VgEbBP0uYrQ607VWcQ9bF1MQEyQaUhfDAuN 9umFx7A+0xd1Ab5ug6qIgme5AF1OVLLKH2x8or1c= Date: Thu, 22 Apr 2021 10:49:10 +0200 From: Greg KH To: Saurav Girepunje Cc: b-liu@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH] usb: musb: davinci: change the variable type Message-ID: References: <20210418183618.GA69452@user> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210418183618.GA69452@user> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 19, 2021 at 12:06:18AM +0530, Saurav Girepunje wrote: > vbus_state is define as bool but on davinci.c assigning a value > '-1' to the bool variable. Does it also test that value? If so, shouldn't that logic error be fixed instead of working around it by changing the variable type? This feels wrong... thanks, greg k-h