Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?utf-8?Q?=C5=81ukasz_Stelmach?= <l.stelmach@samsung.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        =?utf-8?Q?Bart=C5=82omiej_=C5=BBolnierkie?= =?utf-8?Q?wicz?= 
        <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2] hwrng: exynos - Fix runtime PM imbalance on error
Date:   Thu, 22 Apr 2021 13:22:15 +0200
In-Reply-To: <bc20ae4c-3e62-7b07-506c-ce8d90f65754@canonical.com> (Krzysztof
        Kozlowski's message of "Thu, 22 Apr 2021 12:46:42 +0200")
Message-ID: <dleftj35vi7ee0.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <bc20ae4c-3e62-7b07-506c-ce8d90f65754@canonical.com>
        <CGME20210422112224eucas1p283ca7aeaa25ab514b9743a11e63a76e0@eucas1p2.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2021-04-22 czw 12:46>, when Krzysztof Kozlowski wrote:
> On 22/04/2021 12:41, =C5=81ukasz Stelmach wrote:
>> pm_runtime_get_sync() increments the runtime PM usage counter even
>> the call returns an error code. Thus a pairing decrement is needed
>> on the error handling path to keep the counter balanced.
>
> It's exactly the same as Dinghao's patch:
> https://lore.kernel.org/linux-samsung-soc/20200522011659.26727-1-dinghao.=
liu@zju.edu.cn/
> which you reviewed. It has even the same commit msg
> (although it's difficult to be creative here).
>
> I think it's better to resend his patch instead.

It isn't the same because it uses pm_runtime_put_noidle() as discussed
here[1], applied here[2] and advised here[2]. Dinghao didn't prepare
v3[4] for exynos.

[1] https://lore.kernel.org/lkml/20200528065519.GA26960@gondor.apana.org.au/
[2] https://lore.kernel.org/lkml/20200528072106.5191-1-dinghao.liu@zju.edu.=
cn/
[3] https://lore.kernel.org/lkml/20200616073142.GA30519@gondor.apana.org.au/
[4] https://lore.kernel.org/lkml/20200522011659.26727-1-dinghao.liu@zju.edu=
.cn/
=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmCBXGcACgkQsK4enJil
gBC41wf+I2Ag6/aoSYFbS2TtgUWe6hv82FUuQNh+9N3E1lPAGI0qh5cw5v+8/tt1
bzBh8rbyt4d/fr596hjueX2rZJwr98GCb8JRAvPczqXRysEnFlspW/GoeOaDVy8l
tTPJq6PgNtqTVIx/C5xPoJXG9C8dO3Ozhvkb7CTIbVRTRvLAhm4B7307pv0rKobX
+Ho4RCh+FtmpuIuTvwoUMG//I6cO+Oa5rbDjxK0YpEVc5vwVABYKo/JlvyyDp2pe
vrSfuvVJ60ASoXysTfWax6FHa4hX2/1w86JT7CDQVH5JSI7yW9V/8Rg/dYxTpdee
j5TXdZqMkGkVGUrhJ32USAj2EWvAzA==
=ajv9
-----END PGP SIGNATURE-----
--=-=-=--