Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses
To:     Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org,
        Huang Rui <ray.huang@amd.com>, David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org
References: <20210416143725.2769053-1-lee.jones@linaro.org>
 <20210416143725.2769053-28-lee.jones@linaro.org>
 <e5d30ac1-3037-0101-0e1a-9df6a8580c70@amd.com>
 <YH6Wiuy/Vw1Et4Kn@phenom.ffwll.local>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <b0be3dd8-bfe2-6b9d-b6e5-71e3e5b3cceb@amd.com>
Date:   Thu, 22 Apr 2021 14:09:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
In-Reply-To: <YH6Wiuy/Vw1Et4Kn@phenom.ffwll.local>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:2fbd:d2a4:da7e:4526] (2a02:908:1252:fb60:2fbd:d2a4:da7e:4526) by AM4PR0902CA0004.eurprd09.prod.outlook.com (2603:10a6:200:9b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20 via Frontend Transport; Thu, 22 Apr 2021 12:09:35 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ee09c3cf-f97e-4b5b-71d4-08d905877f4d
X-MS-TrafficTypeDiagnostic: MN2PR12MB4391:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB4391DA64ECBCEBFB064A1C1983469@MN2PR12MB4391.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JY6aPMDpIfDc1WTQdg/cPXukbcikU8YbkWf3snfYzuW0ZgNqRP68XstKk6S79ycUCDECHWgNOuBbEq0Rzk1lwjY9OcB1E7f0GKR//kF7l7snvY+xTyubYnctWAoBRzIqI4dWejYXYL9Ac9TY1d2mRfDWfATYdVtp6pKK7d8pMrG5stKxdet7ds7VdSaJHYwZZzOJ12gMAi4yvSYfVS6RCKIg4WMLAXZChSEibyQYmeg71Rjbo36N8HFR0zr1vxYbGmwaUCZpt0TPpoX5NcYU9rWEMnfRLxxzrRV9w3llxVb0aCugLgT+qT41Tc/7+yqSHMB6CbhqPuo3bY3lRK+4EnC2CSrGbqOkg9/SxeayKynDGmIS2p9xGuKdRyM40/xs0XM+SyCTb/va07JHP4OPp4G2HHeGBQSivPbBlr5zb4+50cKZuviGxlUYSXRwdAMc0Lx5hdkYE70sNbMmOT3EQhlHTkTBDJacEUks2uY4dmz/X9/Itb4Oq4rgKIs4m0BokiDYBFhC1Je3uiwH1YIxrZAEmwDEIbkFwZO5193mzBP2ap4HeEQHc7zYYRHSjAHwujtmXcRgSGNTPkZg+7te4VJbZ5+xf0LD43VTRLAj1xZtkDV65EEdacRrEG26o60ieMOorhmbElgpTHuv9onQ/X9+Ncqxt+1z6GBMZOTF2wHGMpJzJ5b18zuGZhKGTPOL
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(366004)(31686004)(31696002)(316002)(86362001)(83380400001)(5660300002)(2906002)(2616005)(66574015)(6666004)(478600001)(52116002)(8936002)(8676002)(38100700002)(6486002)(16526019)(36756003)(66476007)(110136005)(66556008)(66946007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?MzM4SWl3N2NvOFRPY0E1aHp1SDM4Wk9mQklWdFYrUlBLWCtGckRMNVAwM2lv?=
 =?utf-8?B?QVhoL1lpZVJLUko1VFcrRjZaVzdORUtpWmpvRlh5WWdhemJlNmFzajRhTG1y?=
 =?utf-8?B?cGVRbExtdFdEbFg5eXlDQkpJYlh2U3g2enpGTVRHTWlIQkJUZmpWbS8xbzMx?=
 =?utf-8?B?NW96SjJpdUpJbTEwVkpUU3J2eUV6d0UwMVBoS2dDYnUwM2RtY3NlWXFjNU5W?=
 =?utf-8?B?RlF2MlVjWmxZYWtwM0huSktwRTl1cHZlUDk3d2trKy9FYnZSNHVtM01hVjRa?=
 =?utf-8?B?K0psbE55STA3dDluRnlPMVVnRGY1bHVWd09IRDNHWW5LK3k3OFZzODV1T0cx?=
 =?utf-8?B?QmI2aE9IWUlqTVBXeVlEb1c0OFpYM2hlRjN3Z0FUSkF4R3dzdjdoZlRFUkNO?=
 =?utf-8?B?MTJLc0ZqT1Z4WHFzSnh5cXc4ZndtMTBXdUY0Umk0SjJ1dTVEOC9xRmRTSTcw?=
 =?utf-8?B?d2pobkFiQmxHaUFLSEM2bTFvVGVhb0dMZkZ2WFZFTlNNMEk3WVpOOHFxSllE?=
 =?utf-8?B?QS9kL0RWY1phMEpGQldxY0ZTNTRWbjA4Rm1NcnRiTDArRTR3VlFlWW82WlZT?=
 =?utf-8?B?UXdYdlgyNFNrcjJzRXI2eCs4TEZIS2Y3cVYwYjM5QkpZQkVWYXFrMkwyOTlz?=
 =?utf-8?B?NDAzVU5ZaEtZeHZkejlXeE9WVmFpcFRxeHhUMTVBSXRWdjd3Zlkxck92QmZK?=
 =?utf-8?B?cFBId2tVcmpUNjRQbnJqMGZFcUdVMWxUem0xYXFaekEyRUJvV0RPUzJUWWI2?=
 =?utf-8?B?MjVsbk05QkV5Y3laS2djUVRseXBvUkRzS1BweVJMb1J1cWp5L2tFelE0M1hE?=
 =?utf-8?B?V0wrZnIxTys3RldiODgvTDROYk02bTA1eVo0cjRqVmROSmFSUERuZEZ0V0ZD?=
 =?utf-8?B?NDMvd3E1bHROaHphcnJZbW5Gb2F5UGE5MFIyR3RJVEgvWnBRN1ZWcjZxVXZ5?=
 =?utf-8?B?bVh1TUhqd1czVWRYU3BvS2pkMlFBbjJYQm1KSlBObE5sR1FUcHR6KzAxOUg1?=
 =?utf-8?B?SS9SWC81Q1U0SVQ3TjNaTWk0RnlHbzZGK0NhVGNZaG1TZjQvbDdXZnI5Y3Ja?=
 =?utf-8?B?RnUyaS82eDNYSUpzT1JTcFJ6WUZYalBDcDVYc21vY0FJRm1oYWVCeHNMNzRI?=
 =?utf-8?B?em50RmNrK0paK1pVVjBEZ3l4UUF1bUNLeHgwSExuYjRIVDRsN1hQNHNMTHdJ?=
 =?utf-8?B?alFqaW5Wcys1djhiRzVsQk0zMzA5RytIZlRESVJTYSt1a2ZkZ1I4dVMyOUJs?=
 =?utf-8?B?bXRpWWxhSVlhWm1NbkFaOUlield6ZHlXamJmV1B0Y1NCa2t4U1ZyTWY1WnYx?=
 =?utf-8?B?bkl5N3Rqd0JDMWZXV2N2aXF2QWZ3Z2U0YUQxckpwRGVEZE9LamZ1QUxmV1Fl?=
 =?utf-8?B?ZHdyNDJ4RVpnYlBuTWdTc3R1WEV0Y3BpbzVrWUhzb0pPRUdBZGJ0Sm80MStJ?=
 =?utf-8?B?MEZHenRWYTBmL1o1dFhhQWVwWmFQNjN1azVjSDVndHl1U1hFUHYxQWtIN3dQ?=
 =?utf-8?B?eGpBbGRUR1F6am42YjlhRTFGNEhpU2hlWi92OERUSndKVjJGYzJ4WVBINktr?=
 =?utf-8?B?NTZPa1V5TXBLMitYQ1BpaUt0VGwyTE9qMDk0dDhKbW1PMXRqM2h0UVJxbDZD?=
 =?utf-8?B?b0krMmNIaFh0ZkdlV2VCZE5jMDZRR25mSDlDRHE4YUN6bUVmK0R2TjQ2YWJz?=
 =?utf-8?B?ZVFmdElwYkcwbVN2UktKS0RnbEo0NEJHNUYyL2Nwc1lwdTJNcmZINXZ4Q3Vv?=
 =?utf-8?B?QUcrREpuOEExOGxIZnRWZzdRSUxIeW1xNjlsZ3VaQ3g5R0Z2UWFXUlNmMEI2?=
 =?utf-8?B?WHcrMmdpeTdYNyt6UkhGRHNlUTVLVTZ3MFRqZDlKalNGbTNSM0dsZG9XZlJa?=
 =?utf-8?Q?sc6XHgBnOegdz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee09c3cf-f97e-4b5b-71d4-08d905877f4d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2021 12:09:36.6090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 12uT3EKmrXJe0jNQ+YluzLPNFBw1nFmuU8YG1QSlb+6W2U0rRd52SpM0Q56LWS7w
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4391
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 20.04.21 um 10:53 schrieb Daniel Vetter:
> On Fri, Apr 16, 2021 at 05:32:52PM +0200, Christian König wrote:
>> Am 16.04.21 um 16:37 schrieb Lee Jones:
>>> Fixes the following W=1 kernel build warning(s):
>>>
>>>    drivers/gpu/drm/ttm/ttm_device.c:42: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX'
>>>    drivers/gpu/drm/ttm/ttm_device.c:42: warning: expecting prototype for ttm_global_mutex(). Prototype was for DEFINE_MUTEX() instead
>>>    drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'ctx' not described in 'ttm_global_swapout'
>>>    drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'gfp_flags' not described in 'ttm_global_swapout'
>>>    drivers/gpu/drm/ttm/ttm_device.c:112: warning: expecting prototype for A buffer object shrink method that tries to swap out the first(). Prototype was for ttm_global_swapout() instead
>>>
>>> Cc: Christian Koenig <christian.koenig@amd.com>
>>> Cc: Huang Rui <ray.huang@amd.com>
>>> Cc: David Airlie <airlied@linux.ie>
>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>> Cc: dri-devel@lists.freedesktop.org
>>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
> Can you pls also land all the patches you reviewed from Lee into
> drm-misc-next? Just so they wont' get lost. Will all head in for 5.14.

Alex took care of the amdgpu patches and I've just pushed the TTM and 
the scheduler patch to drm-misc-next.

Christian.

> -Daniel
>>> ---
>>>    drivers/gpu/drm/ttm/ttm_device.c | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c
>>> index 9b787b3caeb50..a8bec8358350d 100644
>>> --- a/drivers/gpu/drm/ttm/ttm_device.c
>>> +++ b/drivers/gpu/drm/ttm/ttm_device.c
>>> @@ -36,7 +36,7 @@
>>>    #include "ttm_module.h"
>>> -/**
>>> +/*
>>>     * ttm_global_mutex - protecting the global state
>>>     */
>>>    DEFINE_MUTEX(ttm_global_mutex);
>>> @@ -104,7 +104,7 @@ static int ttm_global_init(void)
>>>    	return ret;
>>>    }
>>> -/**
>>> +/*
>>>     * A buffer object shrink method that tries to swap out the first
>>>     * buffer object on the global::swap_lru list.
>>>     */