Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp419196pxy; Thu, 22 Apr 2021 05:19:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwh/WkZWZ4c6Fxbq3M8EdWw03wKGgH+qjojjGdVf+1C1RwnQCmpDm+szdQts4qrpbLH3dGt X-Received: by 2002:a17:907:70d3:: with SMTP id yk19mr3134818ejb.108.1619093990488; Thu, 22 Apr 2021 05:19:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619093990; cv=none; d=google.com; s=arc-20160816; b=atLEFcQA7POlBZ1tiq6wU9UcUrcu00p1egN8cfeWJQrhGD7Yr9IMx0dyRePlt/wX75 XKgpn/Y13DaT9W7tnlWkOou/J891/xuZUzbB0BHy2vXdK/uyxKM28i5BfZdkAJN4Urg/ nf9CxaoLyJeBp0Itt1rofQXDXqO0bIdP/s4gsReocTow5tdedlEQCPgl+r9we2jSYbwz aeOQ3o7kVasXhw8pGDvPlZLm8k5mAVHLs9iCKawSCEUPz8mXKGqJXQodsGL/Ch5M5i67 3E9YIZGmkkM/e1v5N6MHvW0Q+mfgGLyuIl9SapPusnap9yGwn00/CkNApVyS1RZD9AQd p5OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=EVAvkwBGd871DJQCt8xI0DEWcbmDtBsCE2BVKoisUPI=; b=Mu+BI5sMmVG6+p7fg5yfcjOUbwOksFdyddUT/oBm6uOafriHa5UxJIDsClbcud4MRJ xWro/jNsWLIYy03wulUV7X55XSyXqZdQGHAAx7GkwoYDdBXJ6+BfCr9mxTz5FechCsMv N+9556Ftp+dVP9ewPJflQO8lTAiHYvT3GIxV39eP4/kkc6KkTToVHAqezTZABXRc1EAL udKn2lw0IaKU3/G+ALcBhQ+Dg0MSAhmH426McYliVxFdFA/8XVAFP43eVAPJ7pQcnXhO g2OXyBhdP+wbMa7Gt480TPjExJq/u/P5FczkX4zk0nJwndAuG21Ul2lCPhe+XBa575lx /wSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nd5si1944028ejc.395.2021.04.22.05.19.26; Thu, 22 Apr 2021 05:19:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236125AbhDVMTC (ORCPT + 99 others); Thu, 22 Apr 2021 08:19:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:33102 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235232AbhDVMTC (ORCPT ); Thu, 22 Apr 2021 08:19:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DFBBBADD7; Thu, 22 Apr 2021 12:18:26 +0000 (UTC) Date: Thu, 22 Apr 2021 14:18:29 +0200 From: Borislav Petkov To: Paolo Bonzini Cc: Sean Christopherson , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Lendacky , Brijesh Singh Subject: Re: [PATCH v5 06/15] x86/sev: Drop redundant and potentially misleading 'sev_enabled' Message-ID: <20210422121829.GD6361@zn.tnic> References: <20210422021125.3417167-1-seanjc@google.com> <20210422021125.3417167-7-seanjc@google.com> <8f1fa7e0-b940-6d1d-1a74-11014901fc0d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f1fa7e0-b940-6d1d-1a74-11014901fc0d@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 02:05:46PM +0200, Paolo Bonzini wrote: > Boris or another x86 maintainer, can you ack this small patch? We would > like to use sev_enabled as a static variable in KVM. Yeah, all those "is anything SEV-like enabled" mechanisms would need refactoring before it goes nuts. I think we should do this bool sev_feature_enabled(enum sev_feature) thing at some point: https://lkml.kernel.org/r/20210421144402.GB5004@zn.tnic And TDX would probably need something similar. Thx. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg