Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp476680pxy; Thu, 22 Apr 2021 06:34:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhLWEZ2Cz5Wak41yjwIis78A2YQcfr6Yq15d5tYAGkDkrcg1o+UKb5KNucqprGqYcGRbGk X-Received: by 2002:aa7:c90a:: with SMTP id b10mr3857456edt.276.1619098441845; Thu, 22 Apr 2021 06:34:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619098441; cv=none; d=google.com; s=arc-20160816; b=uf4GrKtvZDHjRFu9PKwx4OuCZ4P9Vt8WZMB+zQiH5LR7Moyq+WDmAFL7Y8Lh7KH2NR gTwPDNYqcrbrY48aq1X7Mu8pA2RhYZcFwd8ZPJRQlQUIk9ZAciIh0tD12wDAM6YDvQhc f9YAofiXoB2kqSsK+h3LU+w1y41H66cYqKzkikFMH2ythjQ15qcdrw3vQJEtliza7T51 nSQwBnzjGcvo1iFnyXLL6JO2fqSj8Uon03GSmsdCjJn2uOwOzkHf35SyDssoZnd7e0CP PRXNBvnDshJZxSJ2vhPw/+XbNrPYbymYAf4vTREAUKETiERwp6J4uJTxvshVlhcDNZ3Q gtAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=AV/EKMZLVMa3xOErDQbK/KIzt28yeOOgvf2yXWUbbMU=; b=knHrCk1y6ugUH3vh5b1mL5tppHl12EonDGLn9kwD4qurkvL0SVkBDUmtnl4iDVqgHE p7+otObFTQFI/V8lNpriQVLxXFBNvMwtmWCbG5VmMCI5HpxzvDVXhQZahGK5OehL7wGv khNTfVHgOcaWRvtgE7PlinBz91eUaZajbp99STFi8ObfOlBOTMJOXK3yHphlECEcWdMG cgFj7Jgc6rDeWK3C816FxQmWLBaD5nqZO1L2U7+cPkgxKyd0qOB9gluH3p4+WcchmQvb Ua5d0E45VMZxMqFCHX7dDjSUoq5hnAVMwv4AEeLWb3agO/VLh+ewgNiE7vIzXt+7Rotn z3tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QpYHQy8S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c18si2338250eds.256.2021.04.22.06.33.35; Thu, 22 Apr 2021 06:34:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QpYHQy8S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236231AbhDVNa5 (ORCPT + 99 others); Thu, 22 Apr 2021 09:30:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:57104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbhDVNau (ORCPT ); Thu, 22 Apr 2021 09:30:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 440136143B; Thu, 22 Apr 2021 13:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619098215; bh=C/N43WVFiAate8dTxtGVLCNXK5ejQ6QClZ0OGp0igFg=; h=From:To:Cc:Subject:Date:From; b=QpYHQy8SOy0EUYU1mSRuGwKtDDDNtQf01s4lNuwJt/PqFZFodPERnsq6qp3RHqy4p gc8fShSOZEtlpcKGmuFkET8LIvqmlgWf4ijvUPKoLTtiNfo4UCszQciSMc2orwKcOF D6EbaHlCn97Tah2INl5MzNA70i/UBCPdWzCngKJPF6Zr/Uki97uwyjr7/IiUC4zhh6 jRzkGkdVKRLMktkXPrRjBtf5/PwKm8I7Aqy9NmiIy6ko7dxAAdSY0aVjNEkXa2X/z3 eWMngcN7ZLzuHwc6bzAovzC03bAWCPElKD5m4CJFe4Cy6voUPYICnr+kG7p2aHz2b6 SMSEqAqvwaa/g== From: Arnd Bergmann To: Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , Stefan Berger , Nayna Jain Cc: Arnd Bergmann , John Johansen , Tyler Hicks , Bruno Meneguele , "Alexander A. Klimov" , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ima: require CONFIG_MODULES for IMA_APPRAISE_MODSIG Date: Thu, 22 Apr 2021 15:29:48 +0200 Message-Id: <20210422132956.1628059-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann When module support is disabled, CONFIG_MODULE_SIG_HASH cannot be set either, so the build process fails with an error certs/Makefile:52: *** Could not determine digest type to use from kernel config. Stop. when IMA_APPRAISE_MODSIG is set but modules are not. Add a Kconfig dependency to prevent this configuration. Fixes: 0165f4ca223b ("ima: enable signing of modules with build time generated key") Signed-off-by: Arnd Bergmann --- security/integrity/ima/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig index 12e9250c1bec..2c36144cdd24 100644 --- a/security/integrity/ima/Kconfig +++ b/security/integrity/ima/Kconfig @@ -242,6 +242,7 @@ config IMA_APPRAISE_MODSIG bool "Support module-style signatures for appraisal" depends on IMA_APPRAISE depends on INTEGRITY_ASYMMETRIC_KEYS + depends on MODULES select PKCS7_MESSAGE_PARSER select MODULE_SIG_FORMAT default n -- 2.29.2