Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 22 Apr 2021 11:46:29 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Ed Tsai <ed.tsai@mediatek.com>
Cc:     <mingo@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] sched: remove the redundant 'success' in the sched
 tracepoint
Message-ID: <20210422114629.2b1ea3ad@gandalf.local.home>
In-Reply-To: <20210422122226.9415-1-ed.tsai@mediatek.com>
References: <20210422122226.9415-1-ed.tsai@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 22 Apr 2021 20:22:26 +0800
Ed Tsai <ed.tsai@mediatek.com> wrote:

> 'success' is left here for a long time and also it is meaningless
> for the upper user. Just remove it.

Have you tested all userspace code that might use this?

This is the "poster boy" example of why Peter Zijlstra hates trace events ;-)

I know I've updated trace-cmd to check to see if this field exits before
depending on it, but there may be some other tools that may not. Perhaps
nothing will break.

I'm all for this change, but be ware, it might be reverted if there's some
tool out that that expects it to exist. This is why it hasn't been removed.

-- Steve