Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ima: require CONFIG_MODULES for IMA_APPRAISE_MODSIG
To:     Arnd Bergmann <arnd@kernel.org>, Mimi Zohar <zohar@linux.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
        James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Stefan Berger <stefanb@linux.ibm.com>,
        Nayna Jain <nayna@linux.ibm.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        John Johansen <john.johansen@canonical.com>,
        Tyler Hicks <tyhicks@linux.microsoft.com>,
        Bruno Meneguele <bmeneg@redhat.com>,
        "Alexander A. Klimov" <grandmaster@al2klimov.de>,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210422132956.1628059-1-arnd@kernel.org>
From:   Nayna <nayna@linux.vnet.ibm.com>
Message-ID: <2fd688d8-9f39-5839-2262-fb703d19d4c3@linux.vnet.ibm.com>
Date:   Thu, 22 Apr 2021 13:23:31 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20210422132956.1628059-1-arnd@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 4/22/21 9:29 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When module support is disabled, CONFIG_MODULE_SIG_HASH cannot
> be set either, so the build process fails with an error
>
> certs/Makefile:52: *** Could not determine digest type to use from kernel config.  Stop.
>
> when IMA_APPRAISE_MODSIG is set but modules are not.
>
> Add a Kconfig dependency to prevent this configuration.
>
> Fixes: 0165f4ca223b ("ima: enable signing of modules with build time generated key")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks Arnd !!

This fix solves the config issue, but adds an unnecessary MODULES 
dependency on APPRAISE_MODSIG. APPRAISE_MODSIG can be used for kernel 
image(appended signature) as well as for kernel modules.

I am working on the fix. I am sorry for the delay, I got stuck with some 
urgent issues early this week.

Thanks & Regards,

       - Nayna