Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] lib/test: convert lib/test_list_sort.c to use KUnit
To:     Daniel Latypov <dlatypov@google.com>,
        andriy.shevchenko@linux.intel.com
Cc:     brendanhiggins@google.com, davidgow@google.com,
        linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org
References: <20210421183222.2557747-1-dlatypov@google.com>
From:   Nico Pache <npache@redhat.com>
Message-ID: <d7b2b598-7087-0445-4647-8521f3238dc2@redhat.com>
Date:   Thu, 22 Apr 2021 16:16:46 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210421183222.2557747-1-dlatypov@google.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hi,

Can we change this to CONFIG_LIST_SORT_KUNIT_TEST to follow the convention used by other KUNIT tests?

Maintainers? thoughts? I recently posted patches to convert some of the other tests that break this format [1].

Cheers,

-- Nico

[1] - https://lkml.org/lkml/2021/4/14/310

On 4/21/21 2:32 PM, Daniel Latypov wrote:
> [SNIP...]
>  config TEST_LIST_SORT
> -	tristate "Linked list sorting test"
> -	depends on DEBUG_KERNEL || m
> +	tristate "Linked list sorting test" if !KUNIT_ALL_TESTS
> +	depends on KUNIT
> +	default KUNIT_ALL_TESTS
> [SNAP...]