Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210421183222.2557747-1-dlatypov@google.com> <d7b2b598-7087-0445-4647-8521f3238dc2@redhat.com>
In-Reply-To: <d7b2b598-7087-0445-4647-8521f3238dc2@redhat.com>
From:   Daniel Latypov <dlatypov@google.com>
Date:   Thu, 22 Apr 2021 13:43:59 -0700
Message-ID: <CAGS_qxp6jNDaEjsZKPeJJVYasXqrfvY5KK0QhXaBh68S7anMRQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] lib/test: convert lib/test_list_sort.c to use KUnit
To:     Nico Pache <npache@redhat.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Brendan Higgins <brendanhiggins@google.com>,
        David Gow <davidgow@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        KUnit Development <kunit-dev@googlegroups.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 22, 2021 at 1:16 PM Nico Pache <npache@redhat.com> wrote:
>
> Hi,
>
> Can we change this to CONFIG_LIST_SORT_KUNIT_TEST to follow the convention used by other KUNIT tests?

I mentioned this in the commit description briefly, but I don't know
who is using this test. Nor do I really know who to ask.
So I didn't want to risk breaking anyone's workflow for now (more than
now requiring them to set CONFIG_KUNIT=y/m).

Side note: maybe CONFIG_KUNIT can default to =y when DEBUG_KERNEL is set?
Then there'd be even less change than how this worked before...

If it's not a concern, I'll happily update the file name and config
option to follow the conventions.

>
> Maintainers? thoughts? I recently posted patches to convert some of the other tests that break this format [1].
>
> Cheers,
>
> -- Nico
>
> [1] - https://lkml.org/lkml/2021/4/14/310
>
> On 4/21/21 2:32 PM, Daniel Latypov wrote:
> > [SNIP...]
> >  config TEST_LIST_SORT
> > -     tristate "Linked list sorting test"
> > -     depends on DEBUG_KERNEL || m
> > +     tristate "Linked list sorting test" if !KUNIT_ALL_TESTS
> > +     depends on KUNIT
> > +     default KUNIT_ALL_TESTS
> > [SNAP...]
>
> --
> You received this message because you are subscribed to the Google Groups "KUnit Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/d7b2b598-7087-0445-4647-8521f3238dc2%40redhat.com.