Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 22 Apr 2021 21:58:20 +0100
From:   Phillip Potter <phil@philpotter.co.uk>
To:     Eric Dumazet <edumazet@google.com>
Cc:     Florian Westphal <fw@strlen.de>,
        Sabrina Dubroca <sd@queasysnail.net>,
        David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: geneve: modify IP header check in geneve6_xmit_skb
Message-ID: <YIHjbNfXyu+zD9Wq@equinox>
References: <20210421231100.7467-1-phil@philpotter.co.uk>
 <CANn89iJwipuJ6tTj5XjnvXnAB3N+dF=8oeCMSUyt+A_cUbr-pw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANn89iJwipuJ6tTj5XjnvXnAB3N+dF=8oeCMSUyt+A_cUbr-pw@mail.gmail.com>
Precedence: bulk

On Thu, Apr 22, 2021 at 08:43:57AM +0200, Eric Dumazet wrote:
> On Thu, Apr 22, 2021 at 1:11 AM Phillip Potter <phil@philpotter.co.uk> wrote:
> >
> > Modify the check in geneve6_xmit_skb to use the size of a struct iphdr
> > rather than struct ipv6hdr. This fixes two kernel selftest failures
> > introduced by commit 6628ddfec758
> > ("net: geneve: check skb is large enough for IPv4/IPv6 header"), without
> > diminishing the fix provided by that commit.
> >
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> 
> SGTM, but _please_ add a Fixes: tag, since stable teams now depend on this,
> more than human parsing the changelog.
> 
> Fixes: 6628ddfec758 ("net: geneve: check skb is large enough for
> IPv4/IPv6 header")
> 

Dear Eric,

Thank you for your feedback, I will make sure the new patch has the
Fixes: tag in it.

Regards,
Phil