Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Valdis Kletnieks <valdis@vt.edu>
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org,
        Kai Huang <kai.huang@intel.com>
Subject: Re: [PATCH] KVM: x86: Fix implicit enum conversion goof in scattered reverse CPUID code
In-Reply-To: <YIBcd+5NKJFnkTC1@archlinux-ax161>
References: <20210421010850.3009718-1-seanjc@google.com>
 <YIBcd+5NKJFnkTC1@archlinux-ax161>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1619155674_38983P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Fri, 23 Apr 2021 01:27:54 -0400
Message-ID: <110961.1619155674@turing-police>
Precedence: bulk

--==_Exmh_1619155674_38983P
Content-Type: text/plain; charset=us-ascii

On Wed, 21 Apr 2021 10:10:15 -0700, Nathan Chancellor said:

> Unfortunately, gcc's -Wenum-conversion is behind -Wextra rather than
> -Wall like clang. If you explicitly enable it with
> KCFLAGS=-Wenum-conversion to your make invocation, it will warn in the
> exact same way as clang:
>
> arch/x86/kvm/cpuid.c: In function 'kvm_set_cpu_caps':
> arch/x86/kvm/cpuid.c:499:29: warning: implicit conversion from 'enum kvm_only_cpuid_leafs' to 'enum cpuid_leafs' [-Wenum-conversion]
>   499 |  kvm_cpu_cap_init_scattered(CPUID_12_EAX,
>       |                             ^~~~~~~~~~~~
> arch/x86/kvm/cpuid.c: In function '__do_cpuid_func':
> arch/x86/kvm/cpuid.c:837:31: warning: implicit conversion from 'enum kvm_only_cpuid_leafs' to 'enum cpuid_leafs' [-Wenum-conversion]
>   837 |   cpuid_entry_override(entry, CPUID_12_EAX);
>       |                               ^~~~~~~~~~~~
>
> clang's warning for comparison/posterity:
>
> arch/x86/kvm/cpuid.c:499:29: warning: implicit conversion from enumeration type 'enum kvm_only_cpuid_leafs' to different enumeration type 'enum cpuid_leafs'
 [-Wenum-conversion]
>         kvm_cpu_cap_init_scattered(CPUID_12_EAX,
>         ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~
> arch/x86/kvm/cpuid.c:837:31: warning: implicit conversion from enumeration type 'enum kvm_only_cpuid_leafs' to different enumeration type 'enum cpuid_leafs'
 [-Wenum-conversion]
>                 cpuid_entry_override(entry, CPUID_12_EAX);
>                 ~~~~~~~~~~~~~~~~~~~~        ^~~~~~~~~~~~
> 2 warnings generated.

Note that this will kill the build if you have CONFIG_KVM_WERROR=y in effect
(which was a reasonable thing to do when KVM built just fine with it in effect).


--==_Exmh_1619155674_38983P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBYIJa2gdmEQWDXROgAQJS8hAAuyGWZ26P+Q93qoKN9KAKX0+D8xuUU3K9
g8Ky+540JLnFCiR6/0WXN1XGISj8VeykmFC4DWTToniWxELf8H4Kby5A3UkWQTGY
rksStkTMhS0Pq9kEOwOPtvJLaTfWhvpPfuA1FADWHpUWYIInymbT+2y9Hda/Ntpz
Q+5nAVf/Q7QYfWtflo8VmxIztrX4winoUav0Scyy5Hc7vbsU7oQZbY9/oedFhv2w
JcZ33B2PoV8ziJl9kSzkXG8Yl5YmyzZek3aWG5gaVAQk+UjhlrTQrKpXZ+m4308a
5RGEENqL4jcR9Gg52MwQkGg4GJVhPHqmKyFPntb0fLkfs2z/bL7/A6ZOYc6hqRX5
mClB3rwRwTgE26Js/N0HL8QA9j2Bp0MiovulScUYOWw0YyC7klsHLIjjT/JRwdtK
/4fq2Ye5oGpN3sWbrO3egfmVBMS3nnkuvlQ7j2tZwQUFUc+QNuEnbBi2yzPcl5hq
CMmdCkbbkAnv01AsvJIl5hiTLWRa6YV6pVLl6n0jEUnmvUH9VDB+yZKB5AVn1MbU
iwF6iUqIcVEla0YAVi6nQudufnzydzkwhr9lzIKg0XuEBGtms51601HDax/fx8Qu
oTEPKnoTwgxqNOC7wyAPZGkMKdDXWhjyWEGt0Z8rJzyJFwVIqVdc+vir6u9/HHod
GHUC8hRYmu0=
=fsOf
-----END PGP SIGNATURE-----

--==_Exmh_1619155674_38983P--