Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Johnny.Chuang" <johnny.chuang@emc.com.tw>
To:     "'Doug Anderson'" <dianders@chromium.org>,
        "'Johnny Chuang'" <johnny.chuang.emc@gmail.com>
Cc:     "'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>,
        "'Benjamin Tissoires'" <benjamin.tissoires@redhat.com>,
        "'Peter Hutterer'" <peter.hutterer@who-t.net>,
        "'LKML'" <linux-kernel@vger.kernel.org>,
        "'open list:HID CORE LAYER'" <linux-input@vger.kernel.org>,
        "'Harry Cutts'" <hcutts@chromium.org>,
        "'James Chen'" <james.chen@emc.com.tw>,
        "'Jennifer Tsai'" <jennifer.tsai@emc.com.tw>,
        "'Paul Liang'" <paul.liang@emc.com.tw>,
        "'Jeff Chuang'" <jeff.chuang@emc.com.tw>,
        "'Jingle'" <jingle.wu@emc.com.tw>
References: <1618276850-27178-1-git-send-email-johnny.chuang.emc@gmail.com> <CAD=FV=VvrWKKbLExpFaDLTDGTam3rbwd7CwTLVFdCY=_c7-eag@mail.gmail.com>
In-Reply-To: <CAD=FV=VvrWKKbLExpFaDLTDGTam3rbwd7CwTLVFdCY=_c7-eag@mail.gmail.com>
Subject: RE: [PATCH v3] HID: i2c-hid: Skip ELAN power-on command after reset
Date:   Fri, 23 Apr 2021 15:54:42 +0800
Message-ID: <011101d73815$eb73ea30$c25bbe90$@emc.com.tw>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Thread-Index: AQG7a3HnjRYiIwf6YyXjsXt955W0TQGCv5oKqu063NA=
Content-Language: zh-tw
Precedence: bulk

> Hi,
> 
> On Mon, Apr 12, 2021 at 6:20 PM Johnny Chuang
> <johnny.chuang.emc@gmail.com> wrote:
> >
> > Fixes: 43b7029f475e ("HID: i2c-hid: Send power-on command after reset").
> 
> Note that the "Fixes" tag actually belongs down at the end. It also shouldn't
> have a "." at the end. Presumably the maintainer can adjust this when landing?
> 

Hi Dmitry,
Could you help to review this patch and give an advice?

> 
> > For ELAN touchscreen, we found our boot code of IC was not flexible
> > enough to receive and handle this command.
> > Once the FW main code of our controller is crashed for some reason,
> > the controller could not be enumerated successfully to be recognized
> > by the system host. therefore, it lost touch functionality.
> >
> > Add quirk for skip send power-on command after reset.
> > It will impact to ELAN touchscreen and touchpad on HID over I2C projects.
> >
> > Signed-off-by: Johnny Chuang <johnny.chuang.emc@gmail.com>
> 
> This patch looks fine to me, thus:
> 
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> 
> I can confirm that after applying this patch I can recovery my borked
> touchscreen (which got borked by a failed firmware update ages ago):
> 
> Tested-by: Douglas Anderson <dianders@chromium.org>