Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] coda: fix reference counting in coda_file_mmap error
 path
To:     Jan Harkes <jaharkes@cs.cmu.edu>
Cc:     linux-kernel@vger.kernel.org, linux-unionfs@vger.kernel.org,
        dri-devel@lists.freedesktop.org, coda@cs.cmu.edu,
        miklos@szeredi.hu, akpm@linux-foundation.org, jgg@ziepe.ca
References: <20210421132012.82354-1-christian.koenig@amd.com>
 <91292A4A-5F97-4FF8-ABAD-42392A0756B5@cs.cmu.edu>
 <f603f59b-ec52-7ad7-475a-fcf95902e145@gmail.com>
 <20210422135103.hif4a5znhzt4pc6f@cs.cmu.edu>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <ckoenig.leichtzumerken@gmail.com>
Message-ID: <1dce6311-c708-19a8-a9cb-489602d6e930@gmail.com>
Date:   Fri, 23 Apr 2021 10:10:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210422135103.hif4a5znhzt4pc6f@cs.cmu.edu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Am 22.04.21 um 15:51 schrieb Jan Harkes:
> On Thu, Apr 22, 2021 at 02:39:41PM +0200, Christian König wrote:
>> Am 22.04.21 um 14:27 schrieb Jan Harkes:
>>> Looks good to me.
>>>
>>> I'm also maintaining an out of tree coda module build that people sometimes use, which has workarounds for differences between the various kernel versions.
>>>
>>> Do you have a reference to the corresponding mmap_region change? If it is merged already I'll probably be able to find it. Is this mmap_region change expected to be backported to any lts kernels?
>> That is the following upstream commit in Linus tree:
>>
>> commit 1527f926fd04490f648c42f42b45218a04754f87
>> Author: Christian König <christian.koenig@amd.com>
>> Date:   Fri Oct 9 15:08:55 2020 +0200
>>
>>      mm: mmap: fix fput in error path v2
>>
>> But I don't think we should backport that.
>>
>> And sorry for the noise. We had so many places which expected different
>> behavior that I didn't noticed that two occasions in the fs code actually
>> rely on the current behavior.
>>
>> For your out of tree module you could make the code version independent by
>> setting the vma back to the original file in case of an error. That should
>> work with both behaviors in mmap_region.
> Awesome, I'll give that a try, it may very well be a cleaner solution
> either way.
>
> And thank you for following up after your original patch and finding
> the filesystems that mess around with those mappings. I'm sure it would
> have taken me a while to figure out why file refcounts would go weird
> for some people, especially because this only happens in the error path.

Kudos goes to Miklos for figured out why the refcount for overlayfs was 
suddenly wrong.

And please also see the follow up commit:

commit 295992fb815e791d14b18ef7cdbbaf1a76211a31 (able/vma_file)
Author: Christian König <christian.koenig@amd.com>
Date:   Mon Sep 14 15:09:33 2020 +0200

     mm: introduce vma_set_file function v5

It adds a new vma_set_file() function which implements the necessary 
refcount dance for changing the vma file in a clean manner.

Thanks,
Christian.

>
> Jan
>