Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1619161883-5963-1-git-send-email-wanpengli@tencent.com> <f025b59c-5a8a-abf7-20fc-323a5b450ba5@redhat.com>
In-Reply-To: <f025b59c-5a8a-abf7-20fc-323a5b450ba5@redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Fri, 23 Apr 2021 16:15:18 +0800
Message-ID: <CANRm+CxcqMW-m7WNmMv6uP3DusPTWmizf3AwOh9tY43HgrugBg@mail.gmail.com>
Subject: Re: [PATCH] KVM: x86/xen: Take srcu lock when accessing kvm_memslots()
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 23 Apr 2021 at 16:13, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 23/04/21 09:11, Wanpeng Li wrote:
> > From: Wanpeng Li <wanpengli@tencent.com>
> >
> > kvm_memslots() will be called by kvm_write_guest_offset_cached() so
> > take the srcu lock.
> >
> > Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>
> Good catch.  But I would pull it from kvm_steal_time_set_preempted to
> kvm_arch_vcpu_put instead.

Will do. :)

    Wanpeng