Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210415073338.22287-1-dinghao.liu@zju.edu.cn>
 <CAMuHMdVgtZkO3FfLOph41cXXJbSuc16UX1Z+fD0_iNN7nM-GtA@mail.gmail.com> <2fd8490f.73bcd.178fdc55590.Coremail.dinghao.liu@zju.edu.cn>
In-Reply-To: <2fd8490f.73bcd.178fdc55590.Coremail.dinghao.liu@zju.edu.cn>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 23 Apr 2021 10:15:55 +0200
Message-ID: <CAMuHMdUdDYo9CYWCgJvYLibBef-4NvM5aHHWbB2NP6ie22U=SA@mail.gmail.com>
Subject: Re: Re: [PATCH] [v3] clk: renesas: rcar-usb2-clock-sel: Fix error
 handling in rcar_usb2_clock_sel_probe
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc:     Kangjie Lu <kjlu@umn.edu>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Dinghao,

On Fri, Apr 23, 2021 at 10:08 AM <dinghao.liu@zju.edu.cn> wrote:
> > On Thu, Apr 15, 2021 at 9:33 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
> > > The error handling paths after pm_runtime_get_sync() has no
> > > refcount decrement, which leads to refcount leak.
> > >
> > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > > ---
> > >
> > > Changelog:
> > >
> > > v2: - Move the position of pm_runtime_enable,_get_sync().
> > >       Use devm_clk_register() to simplify error handling.
> >
> > Thanks for the update!
> >
> > > --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > > +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > > @@ -131,7 +131,6 @@ static int rcar_usb2_clock_sel_remove(struct platform_device *pdev)
> > >         struct usb2_clock_sel_priv *priv = platform_get_drvdata(pdev);
> >
> >     warning: unused variable ‘priv’ [-Wunused-variable]
> >
> > Have you compiled this?
> >
>
> This is my carelessness, thanks for pointing out this. When we use
> devm_clk_hw_register(), we will not need to unregister priv->hw in
> rcar_usb2_clock_sel_remove(). So I think it's okay to remove
> platform_get_drvdata() in it to eliminate this warning.
>
> Do you need a new version of patch to fix this warning?

I'll remove that line while applying, so no need to fix and resend.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds