Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1162907pxy; Fri, 23 Apr 2021 01:31:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymg8oCHhbI4OkTJA8bGvLj4R79c9uyWD1gO8kk51TiNqFxGvqi7k4gxZV6XM0PDpiVU45C X-Received: by 2002:a17:90a:9503:: with SMTP id t3mr3140260pjo.220.1619166691483; Fri, 23 Apr 2021 01:31:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619166691; cv=none; d=google.com; s=arc-20160816; b=qtmycS3mLQsHPYy3drvahgJVfAYG3CNgIB9Xcijye9Q7ci/QRfGuPoY29U7IHdqs6G SgQdnDpdJnSUlFBQjO+hA6gsOePieyqbADXRRpA+7T1Yi1GWfHqCXijM38EK7MUHoMkV KURPmOtAsIiy41b+OPzh7S4HO07jJ0TQqno2v2JHavud+DatHCF7SfzRWwe0b/cJtODq iwdFbptp3MpzqamM/tYwM1rp0kFK4zoFJkY5/oWXpgp56xx5i/jWRjBqo9/VSD3R1oku YIoWz+o//A2CGF2J2adamrzXRw9u0io1jeK+pqZlXDnCFfH6+GDzrj7BwkRv3PV1GmOb qczA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:to:from; bh=BsDrlD6UyMfVKktYtGnIvExz7HVESSZguHJRXitZzJ0=; b=SCEUq4GYLKUqVECJ63zcgVfTvxWsyyMVzPLjZO7uuaXAC4g466ppG2pCBlh8RXXat/ P5D2faZ8vnZRmwlpkm/6GjuwwHo0KOQDf/rIdW61jVUTJtS7jAZqUPet9/IHR2jFQOQx Z1Lk17Lg91kNPJxqR6yE7iFfW7jd1MeJbu7gkOMp7/gvi+4vXu7SfddM6TBWT1o5n7rE WTxZejYowUruPeI8qhk46VUR92rO55I12eclXLX3/9eUtmrlVHXdiyySUSIfAgq2lzxF MRc1cUzrcf6LVE/sn8w3IZy7W3ssWM4ZfKJv6KvBAShKduapfMfUmH2x4RH/uQJgp/uZ KLEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si5977257pjp.134.2021.04.23.01.31.17; Fri, 23 Apr 2021 01:31:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241430AbhDWIbL (ORCPT + 99 others); Fri, 23 Apr 2021 04:31:11 -0400 Received: from mail-m118208.qiye.163.com ([115.236.118.208]:31558 "EHLO mail-m118208.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbhDWIbK (ORCPT ); Fri, 23 Apr 2021 04:31:10 -0400 Received: from ubuntu.localdomain (unknown [36.152.145.182]) by mail-m118208.qiye.163.com (Hmail) with ESMTPA id 26CBCE040D; Fri, 23 Apr 2021 16:30:31 +0800 (CST) From: zhouchuangao To: Thomas Bogendoerfer , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, zhouchuangao , linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] mips/bcm63xx: Use BUG_ON instead of if condition followed by BUG Date: Fri, 23 Apr 2021 01:30:21 -0700 Message-Id: <1619166623-70445-1-git-send-email-zhouchuangao@vivo.com> X-Mailer: git-send-email 2.7.4 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZQ0pKT1YeTEIZQxkaSxlLTU9VEwETFhoSFyQUDg9ZV1kWGg8SFR0UWUFZT0tIVUpKS0 hKTFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MDo6HSo4GT8KAgxKDCscAjAN Nj0aChlVSlVKTUpCSk1NTUhKTUNJVTMWGhIXVQETFA4YEw4aFRwaFDsNEg0UVRgUFkVZV1kSC1lB WUhNVUpOSVVKT05VSkNJWVdZCAFZQUlJTUo3Bg++ X-HM-Tid: 0a78fdda159d2c17kusn26cbce040d Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BUG_ON uses unlikely in if(), it can be optimized at compile time. Usually, the condition in if() is not satisfied. In my opinion, this can improve the efficiency of the multi-stage pipeline. Signed-off-by: zhouchuangao --- arch/mips/bcm63xx/gpio.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/mips/bcm63xx/gpio.c b/arch/mips/bcm63xx/gpio.c index 16f353a..5c4a233 100644 --- a/arch/mips/bcm63xx/gpio.c +++ b/arch/mips/bcm63xx/gpio.c @@ -43,8 +43,7 @@ static void bcm63xx_gpio_set(struct gpio_chip *chip, u32 *v; unsigned long flags; - if (gpio >= chip->ngpio) - BUG(); + BUG_ON(gpio >= chip->ngpio); if (gpio < 32) { reg = gpio_out_low_reg; @@ -70,8 +69,7 @@ static int bcm63xx_gpio_get(struct gpio_chip *chip, unsigned gpio) u32 reg; u32 mask; - if (gpio >= chip->ngpio) - BUG(); + BUG_ON(gpio >= chip->ngpio); if (gpio < 32) { reg = gpio_out_low_reg; @@ -92,8 +90,7 @@ static int bcm63xx_gpio_set_direction(struct gpio_chip *chip, u32 tmp; unsigned long flags; - if (gpio >= chip->ngpio) - BUG(); + BUG_ON(gpio >= chip->ngpio); if (gpio < 32) { reg = GPIO_CTL_LO_REG; -- 2.7.4