Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Xu Yihang <xuyihang@huawei.com>
Cc:     mingo@kernel.org, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
        dwmw@amazon.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] x86/apic: Force logial APIC ID in range from 0 to 8
In-Reply-To: <20210423075324.133463-1-xuyihang@huawei.com>
References: <20210423075324.133463-1-xuyihang@huawei.com>
Date:   Fri, 23 Apr 2021 10:37:26 +0200
Message-ID: <87czulwg55.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 23 2021 at 15:53, Xu Yihang wrote:
> According to Intel 64 and IA-32 Architectures Software Developer=E2=80=99=
s Manuals
> Vol. 3A 10.6.2.2, Logical APIC ID locates on bit 24 to 31, can only
> support up to 8 local APIC under flat mode. Also C99 says left shift exce=
eding
> maximum value representable in the result type is undefined behavior. But
> under x86 architecture, it seems doesn't do any actual damage.
>
> There is KASAN warning on a 80 cores machine after booting #64 CPU.
> ```
> [    1.681097] UBSAN: Undefined behaviour in arch/x86/kernel/apic/apic_fl=
at_64.c:51:11
> [    1.688739] shift exponent 64 is too large for 64-bit type 'long unsig=
ned int'
> ```

This function should not be invoked on a 80 core machine at all.

Can you please add 'apic=3Dverbose' to the kernel command line and provide
a full boot log?

Thanks,

        tglx