Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wp2JxWHYdvm7r3Gs0TaLbAmN7MUgisK3F+b0U6iEdxEBAgOmIBGuKCena2gXNO0ivpGAtAjacC
 wGDlHdeWdDCQ==
IronPort-SDR: IK0TxGxWGEFhBNEP4++Sgugv9p7pvzafR2d5LbInWGeSRF5zs6grFvTtQ1/GKI4t8uZFAFJlB1
 PINhL9bh4YsA==
From:   "Ismail, Mohammad Athari" <mohammad.athari.ismail@intel.com>
To:     Vladimir Oltean <olteanv@gmail.com>
CC:     Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "Voon, Weifeng" <weifeng.voon@intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 net-next] net: pcs: Enable pre-emption packet for
 10/100Mbps
Thread-Topic: [PATCH v2 net-next] net: pcs: Enable pre-emption packet for
 10/100Mbps
Thread-Index: AQHXN8w75Vo0bmfsFEyfZYnEbB76e6rBNbyAgAAK1lCAAAXiAIAAkBXg
Date:   Fri, 23 Apr 2021 09:30:07 +0000
Message-ID: <CO1PR11MB47716991AAEA525773FEAFC8D5459@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20210422230645.23736-1-mohammad.athari.ismail@intel.com>
 <20210422235317.erltirtrxnva5o2d@skbuf>
 <CO1PR11MB4771A73442ECD81BEC2F1F04D5459@CO1PR11MB4771.namprd11.prod.outlook.com>
 <20210423005308.wnhpxryw6emgohaa@skbuf>
In-Reply-To: <20210423005308.wnhpxryw6emgohaa@skbuf>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: cad1625b-d7ec-4c1f-5def-08d9063a61fa
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2021 09:30:07.0278
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qqMfnnuPh/kY4KDANVVknvsUPVd5saNSFPV05P4amemC6xlm94JQNF7JmIszqqhxT6qv92yCtUFJ/HhwmisdGa7XWuh6CJGdV8yf20dEW2d9dApmlzT8t/raMCzKu0fr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1312
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vladimir,

> -----Original Message-----
> From: Vladimir Oltean <olteanv@gmail.com>
> Sent: Friday, April 23, 2021 8:53 AM
> To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>; Jose Abreu
> <joabreu@synopsys.com>; David S . Miller <davem@davemloft.net>; Jakub
> Kicinski <kuba@kernel.org>; Andrew Lunn <andrew@lunn.ch>; Heiner Kallweit
> <hkallweit1@gmail.com>; Russell King <linux@armlinux.org.uk>; Ong, Boon
> Leong <boon.leong.ong@intel.com>; Voon, Weifeng
> <weifeng.voon@intel.com>; Wong, Vee Khee <vee.khee.wong@intel.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 net-next] net: pcs: Enable pre-emption packet for
> 10/100Mbps
>=20
> On Fri, Apr 23, 2021 at 12:45:25AM +0000, Ismail, Mohammad Athari wrote:
> > Hi Vladimir,
> >
> > > -----Original Message-----
> > > From: Vladimir Oltean <olteanv@gmail.com>
> > > Sent: Friday, April 23, 2021 7:53 AM
> > > To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> > > Cc: Alexandre Torgue <alexandre.torgue@st.com>; Jose Abreu
> > > <joabreu@synopsys.com>; David S . Miller <davem@davemloft.net>;
> > > Jakub Kicinski <kuba@kernel.org>; Andrew Lunn <andrew@lunn.ch>;
> > > Heiner Kallweit <hkallweit1@gmail.com>; Russell King
> > > <linux@armlinux.org.uk>; Ong, Boon Leong <boon.leong.ong@intel.com>;
> > > Voon, Weifeng <weifeng.voon@intel.com>; Wong, Vee Khee
> > > <vee.khee.wong@intel.com>; netdev@vger.kernel.org;
> > > linux-kernel@vger.kernel.org
> > > Subject: Re: [PATCH v2 net-next] net: pcs: Enable pre-emption packet
> > > for 10/100Mbps
> > >
> > > Hi Mohammad,
> > >
> > > On Fri, Apr 23, 2021 at 07:06:45AM +0800,
> > > mohammad.athari.ismail@intel.com
> > > wrote:
> > > > From: Mohammad Athari Bin Ismail
> > > > <mohammad.athari.ismail@intel.com>
> > > >
> > > > Set VR_MII_DIG_CTRL1 bit-6(PRE_EMP) to enable pre-emption packet
> > > > for 10/100Mbps by default. This setting doesn`t impact pre-emption
> > > > capability for other speeds.
> > > >
> > > > Signed-off-by: Mohammad Athari Bin Ismail
> > > > <mohammad.athari.ismail@intel.com>
> > > > ---
> > >
> > > What is a "pre-emption packet"?
> >
> > In IEEE 802.1 Qbu (Frame Preemption), pre-emption packet is used to
> > differentiate between MAC Frame packet, Express Packet, Non-fragmented
> > Normal Frame Packet, First Fragment of Preemptable Packet,
> > Intermediate Fragment of Preemptable Packet and Last Fragment of
> > Preemptable Packet.
>=20
> Citation needed, which clause are you referring to?

Cited from IEEE802.3-2018 Clause 99.3.

>=20
> >
> > This bit "VR_MII_DIG_CTRL1 bit-6(PRE_EMP)" defined in DesignWare Cores
> > Ethernet PCS Databook is to allow the IP to properly receive/transmit
> > pre-emption packets in SGMII 10M/100M Modes.
>=20
> Shouldn't everything be handled at the MAC merge sublayer? What business
> does the PCS have in frame preemption?

There is no further detail explained in the databook w.r.t to VR_MII_DIG_CT=
RL1 bit-6(PRE_EMP). The only statement it mentions is "This bit should be s=
et to 1 to allow the DWC_xpcs to properly receive/transmit pre-emption pack=
ets in SGMII 10M/100M Modes".

>=20
> Also, I know it's easy to forget, but Vinicius' patch series for supporti=
ng frame
> preemption via ethtool wasn't accepted yet. How are you testing this?

For stmmac Kernel driver, frame pre-emption capability is already supported=
. For iproute2 (tc command), we are using custom patch based on Vinicius pa=
tch.