Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1203853pxy; Fri, 23 Apr 2021 02:49:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBl+MPAVc2y8X1RhHesxLf85jT2Cg7fJ4z3J4FX/JUMjz3KHmxreB4pWEMUNpKnWS2bTDo X-Received: by 2002:a05:6402:453:: with SMTP id p19mr3415984edw.88.1619171385933; Fri, 23 Apr 2021 02:49:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619171385; cv=none; d=google.com; s=arc-20160816; b=bmX8Mg+oS03wKaPSn/yK8ZhkxO/x+N/mhxhadTOZ5+2Zw634maB1T0QgrfQY/9wLNv P5kjqtzNyUx010HOAVQavOI57K03nunwVi3Jbi2ld3HOWzZ8UCuzoxWQxGh96A8EbE1B DrEB3gguMm7bcxWXAJlqtet3WULDfQHDl7Kv1LHdvdJ4oeMXBiGJ6qwmlD49ep2CXhyo TaWMuLFbt7aL/qZPz+KXAfm3KmpJHEEj/MwkEGjQUnOulXHzYbSAfRSLUnh+/Sjcbykg PMjeZTcK7Gz4IDm/pDPidM/plbuo6tRTiA6vzIFnUtLVNNr+PIlBuKNyiQVNeFEVsLaz tQ/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oxygRQPAIj5GbSMgCAW5cRAUHCNpVml6SUhLAkII8TE=; b=vjspD+Vb+fNDK+n93fB2PJgJjPjdM+CcmYCxIbqIHyvFtTDxOWG4K93CxU72v2EEHf TfIqmpha5wO4Pvj00LQq1+Hc4vPxKqstrB5L4QueSFKEg/11t26KQfSGMzQyehfFNySi A2d1xB4v69Y8BhmSSzttav1bUO7skuBOknlEpKk3sI4WRP1W1BbvURxuVgLBV02Pzr7z jOz2PxqUHEHDlLyiAFAXT4j2euVnNxKVIX+wbWvsTW+yMMT53LcF5hJX4zBXDJsfaarN Rv9LkvyHCZg1ejysXNhEDSQKk1sSWW3ql6RAs3PJOXSv7QnsFOcHO3ravK/he9WJRM+D YyrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qM98FsSt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nd31si4522868ejc.355.2021.04.23.02.49.21; Fri, 23 Apr 2021 02:49:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qM98FsSt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241822AbhDWJrB (ORCPT + 99 others); Fri, 23 Apr 2021 05:47:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:34882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241818AbhDWJrA (ORCPT ); Fri, 23 Apr 2021 05:47:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 145FE6145A; Fri, 23 Apr 2021 09:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619171183; bh=/LwOVaqw7XghWY9GSpGQLWfkHq5XaYKaIg1dmpHiTko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qM98FsStJXi3Tc1KoYyH5JDlZWOjXxY2s96Wd9beM3wGk+JXnAkMcnZGQpqTCv7gw MSwnKANmOFSiKmoXszXPbYphXuriiEzv6VraWLr8Ts2wUS8Cw/TRq8Yrus4sxW/zYh jO2glAtHXw3ogf3O/SFEAbr7xzlZEA8YSg4V7wNY= Date: Fri, 23 Apr 2021 11:46:20 +0200 From: Greg Kroah-Hartman To: Lee Jones Cc: linux-kernel@vger.kernel.org, Kangjie Lu Subject: Re: [PATCH 165/190] Revert "mfd: mc13xxx: Fix a missing check of a register-read failure" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-166-gregkh@linuxfoundation.org> <20210423093042.GE6446@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423093042.GE6446@dell> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 10:30:42AM +0100, Lee Jones wrote: > On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote: > > > This reverts commit 9e28989d41c0eab57ec0bb156617a8757406ff8a. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu > > Cc: Lee Jones > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/mfd/mc13xxx-core.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c > > index 1abe7432aad8..b2beb7c39cc5 100644 > > --- a/drivers/mfd/mc13xxx-core.c > > +++ b/drivers/mfd/mc13xxx-core.c > > @@ -271,9 +271,7 @@ int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, > > > > mc13xxx->adcflags |= MC13XXX_ADC_WORKING; > > > > - ret = mc13xxx_reg_read(mc13xxx, MC13XXX_ADC0, &old_adc0); > > - if (ret) > > - goto out; > > + mc13xxx_reg_read(mc13xxx, MC13XXX_ADC0, &old_adc0); > > > > adc0 = MC13XXX_ADC0_ADINC1 | MC13XXX_ADC0_ADINC2 | > > MC13XXX_ADC0_CHRGRAWDIV; > > Thanks for bringing this commit to my attention. > > The associated LWN article was an interesting read and I have to say, > I was very disappointed to hear about the actions of these so called > researchers. > > Upon re-review of the original commit, this one does appear valid. > > Do I need to conduct anymore due diligence or can I drop this patch? Nope, that's it, I'll drop this from my series, thanks for the review! greg k-h