Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1225327pxy; Fri, 23 Apr 2021 03:21:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8V+2p2oWTyocuBXEf5pbJvaMY9tl3GwTWI++O1a86+Sd40uO6mAjLJs7o/j6ar/erVKYy X-Received: by 2002:a17:90a:8d82:: with SMTP id d2mr3548682pjo.200.1619173269134; Fri, 23 Apr 2021 03:21:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619173269; cv=none; d=google.com; s=arc-20160816; b=BlZrsRghWxjqQXCbzAXnOiifCpIankelK3aJYc+pZZVJvAosEHuUor1cIuLKWGa0qA mXOEKMjaIxMNfJFBKWp3yJ7c+Y7PqLhbz3j38v3q2t+RR/QJqrK1Is6RZl3yRX9YGgED 76qyt7Q7B9oCudR8e4D9DbX1DAf3vHX6Y3WP+v2cHdVNryuPBjrdQoDCIdtBjoHWMuJV V9Vg6oLPgjgJvCsAHfWXsWmRxhTdoPe5hppDl6QUSpDgGIV6wkEtzzipTZRVuSn0tDIg VAHAl2bPsMWdxqFhTvH+nOc+7L8jxPL4LMdlU/Jz3lzNCTwyQq5oGdk7qQHvSLyAOJ76 Slkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=EC3zoWq2BZfFb/EWRvBNqc9bpLHCgYUaPIXnRPSJVLg=; b=Oh8SLZhCuXa7Ly1zzI5MtE/AuuGTmPkuvp6JHcnwAM4HiClj7K0ZTGTxG65qVMwJd/ zZA6PSWvye3T/8PRCgvNyJBUa0nRWcTvY5RGQPaHNQyajof4KuaGZVeEGNpYyE0ZxBtM m4XBkKa6aMwmpiCLRQKJApcU4bEGUDuyMrISQeMcd0o11OxlsOrdDhaST5t1h1/1We4b cjH59OzgE1GWo8O6x/TnHgL1I9TYWiropTEKpZmVMI6A1mwOoId4X6SqTz2i9cmGLwqz 5A/3vI3Vje7YvKS/dOD8BZ6v36+WdIsy8zCsRH1B2B4zOHruoJ3dMCTQ3U/U3YlNNv76 UiXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n24si5999857pjq.168.2021.04.23.03.20.56; Fri, 23 Apr 2021 03:21:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241927AbhDWKS6 (ORCPT + 99 others); Fri, 23 Apr 2021 06:18:58 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42116 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236064AbhDWKS4 (ORCPT ); Fri, 23 Apr 2021 06:18:56 -0400 Received: from mail-wm1-f72.google.com ([209.85.128.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lZst9-0001bH-GW for linux-kernel@vger.kernel.org; Fri, 23 Apr 2021 10:18:19 +0000 Received: by mail-wm1-f72.google.com with SMTP id d78-20020a1c1d510000b0290132794b7801so581028wmd.1 for ; Fri, 23 Apr 2021 03:18:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EC3zoWq2BZfFb/EWRvBNqc9bpLHCgYUaPIXnRPSJVLg=; b=jCnrydZpS2A4uq3N47mACZJbosc54an/oWCPpbSJKiu1V599jJZxlAlApU8Nr2Ht6m j++z03gkP40BxXVHQr3vJpskCF1f9ctAO9sJr8dnRK+hq3PPV3t59qdJ/fgzhDAd819f PyT3+XR5nJI9HQnDfoAQFIMjZg01zbxP7VrXGdQoDrhidmhBoV2EHvfjjSvhfmkiFCLn 437tpwSHdn0ao671lIuaSMCjLLwL0Vg+xj+UoM3O8WiUAYFwd2J2GXwRxwgz/o6LptfB PGzsgJ9aF8X6+XictJXMJRbKsjZl6UzujVoj6o0HQbBHyBw9+zBkIvQKEJO9N1lF6K4G 2D+w== X-Gm-Message-State: AOAM531n7r40aYxqu0W+ItJkwbWelciwmEseRncuqsZdkeJi/aQyE+0o rl7bIHqQUGHUy/vqTabbzwcNOqkfIa1cZ9eY3VLemI2b4vENyYE7RV84lALT7q/EwoxSNiRDjzR ClspYIHr2UhyiSHjEKKv9fTgXEEBbPPu6ucPRQBn4lA== X-Received: by 2002:a5d:6ac6:: with SMTP id u6mr3767662wrw.290.1619173099133; Fri, 23 Apr 2021 03:18:19 -0700 (PDT) X-Received: by 2002:a5d:6ac6:: with SMTP id u6mr3767654wrw.290.1619173099028; Fri, 23 Apr 2021 03:18:19 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id k22sm9011546wrh.5.2021.04.23.03.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 03:18:18 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Maxime Coquelin , Alexandre Torgue , Christophe Kerello , Miquel Raynal , Boris Brezillon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH 2/2] memory: atmel-ebi: add missing of_node_put for loop iteration Date: Fri, 23 Apr 2021 12:18:15 +0200 Message-Id: <20210423101815.119341-2-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210423101815.119341-1-krzysztof.kozlowski@canonical.com> References: <20210423101815.119341-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Early exits from for_each_available_child_of_node() should decrement the node reference counter. Reported by Coccinelle: drivers/memory/atmel-ebi.c:593:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 604. Fixes: 6a4ec4cd0888 ("memory: add Atmel EBI (External Bus Interface) driver") Signed-off-by: Krzysztof Kozlowski --- drivers/memory/atmel-ebi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c index 14386d0b5f57..c267283b01fd 100644 --- a/drivers/memory/atmel-ebi.c +++ b/drivers/memory/atmel-ebi.c @@ -600,8 +600,10 @@ static int atmel_ebi_probe(struct platform_device *pdev) child); ret = atmel_ebi_dev_disable(ebi, child); - if (ret) + if (ret) { + of_node_put(child); return ret; + } } } -- 2.25.1