Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161318AbWJRTdg (ORCPT ); Wed, 18 Oct 2006 15:33:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161320AbWJRTdg (ORCPT ); Wed, 18 Oct 2006 15:33:36 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:57836 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S1161318AbWJRTdf (ORCPT ); Wed, 18 Oct 2006 15:33:35 -0400 Message-ID: <4536818E.3060505@fr.ibm.com> Date: Wed, 18 Oct 2006 21:33:34 +0200 From: Cedric Le Goater User-Agent: Thunderbird 1.5.0.7 (X11/20060913) MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: Gabriel C , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: 2.6.19-rc2-mm1 References: <20061016230645.fed53c5b.akpm@osdl.org> <45367210.4040507@googlemail.com> <200610182118.31371.rjw@sisk.pl> In-Reply-To: <200610182118.31371.rjw@sisk.pl> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 48 Rafael J. Wysocki wrote: > On Wednesday, 18 October 2006 20:27, Gabriel C wrote: >> Andrew Morton wrote: >>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc2/2.6.19-rc2-mm1/ >>> >> Hello, >> >> I got this build error with 2.6.19-rc2-mm1: >> >> CHK include/linux/compile.h >> UPD include/linux/compile.h >> CC init/version.o >> LD init/built-in.o >> LD .tmp_vmlinux1 >> mm/built-in.o: In function `xip_file_write': >> (.text+0x19a47): undefined reference to `filemap_copy_from_user' >> make: *** [.tmp_vmlinux1] Error 1 > > \metoo Here's a fix i sent to andrew. C. Signed-off-by: Cedric Le Goater --- mm/filemap_xip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: 2.6.19-rc2-mm1/mm/filemap_xip.c =================================================================== --- 2.6.19-rc2-mm1.orig/mm/filemap_xip.c +++ 2.6.19-rc2-mm1/mm/filemap_xip.c @@ -317,7 +317,7 @@ __xip_file_write(struct file *filp, cons break; } - copied = filemap_copy_from_user(page, offset, buf, bytes); + copied = filemap_copy_from_user_atomic(page, offset, buf, bytes); flush_dcache_page(page); if (likely(copied > 0)) { status = copied; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/