Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Apr 2021 12:47:55 +0100
Message-ID: <87r1j1nrx0.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Mark Rutland <mark.rutland@arm.com>
Cc:     He Ying <heying24@huawei.com>, tglx@linutronix.de,
        julien.thierry.kdev@gmail.com, catalin.marinas@arm.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH v2] irqchip/gic-v3: Do not enable irqs when handling spurious interrups
In-Reply-To: <20210423105051.GA83097@C02TD0UTHF1T.local>
References: <20210423083516.170111-1-heying24@huawei.com>
        <20210423105051.GA83097@C02TD0UTHF1T.local>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 23 Apr 2021 11:50:51 +0100,
Mark Rutland <mark.rutland@arm.com> wrote:

[...]

> > Fixes: 17ce302f3117 ("arm64: Fix interrupt tracing in the presence of NMIs")
> > Signed-off-by: He Ying <heying24@huawei.com>
> 
> I'm reckon the fixes tag should probably be either:
> 
> Fixes: f32c926651dcd168 ("irqchip/gic-v3: Handle pseudo-NMIs")
> 
> ... or:
> 
> Fixes: 3f1f3234bc2db1c1 (" irqchip/gic-v3: Switch to PMR masking before calling IRQ handler")
> 
> ... since the underlying issue is that gic_handle_irq() unmasks DAIF.I
> and permits unintended nesting, even if that doesn't trigger a BUG() at
> that point.

I used the latter (see 161917211934.29796.1841651233234902273.tip-bot2@tip-bot2).

> Otherwise, this makes sense to me:
> 
> Acked-by: Mark Rutland <mark.rutland@arm.com>

I'll update the commit to reflect this.

Thanks.

	M.

-- 
Without deviation from the norm, progress is not possible.