Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Apr 2021 15:41:17 +0200
From:   Sabrina Dubroca <sd@queasysnail.net>
To:     Phillip Potter <phil@philpotter.co.uk>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, edumazet@google.com, fw@strlen.de
Subject: Re: [PATCH v2] net: geneve: modify IP header check in
 geneve6_xmit_skb and geneve_xmit_skb
Message-ID: <YILOfTt6qKNwYtV6@hog>
References: <20210422234945.1190-1-phil@philpotter.co.uk>
MIME-Version: 1.0
In-Reply-To: <20210422234945.1190-1-phil@philpotter.co.uk>
Content-Type: text/plain; charset=UTF-8
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
Precedence: bulk

2021-04-23, 00:49:45 +0100, Phillip Potter wrote:
> Modify the header size check in geneve6_xmit_skb and geneve_xmit_skb
> to use pskb_inet_may_pull rather than pskb_network_may_pull. This fixes
> two kernel selftest failures introduced by the commit introducing the
> checks:
> IPv4 over geneve6: PMTU exceptions
> IPv4 over geneve6: PMTU exceptions - nexthop objects
> 
> It does this by correctly accounting for the fact that IPv4 packets may
> transit over geneve IPv6 tunnels (and vice versa), and still fixes the
> uninit-value bug fixed by the original commit.
> 
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Fixes: 6628ddfec758 ("net: geneve: check skb is large enough for IPv4/IPv6 header")
> Suggested-by: Sabrina Dubroca <sd@queasysnail.net>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> 
> V2:
> * Incorporated feedback from Sabrina Dubroca regarding pskb_inet_may_pull
> * Added Fixes: tag as requested by Eric Dumazet

Thanks Phillip.

Acked-by: Sabrina Dubroca <sd@queasysnail.net>

Jakub/David, it would be great if this could get in 5.12, otherwise
geneve is a bit broken:
https://bugzilla.kernel.org/show_bug.cgi?id=212749

-- 
Sabrina