Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1375961pxy; Fri, 23 Apr 2021 06:47:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5Enpirt13dHOWoEiNZl+iMfPO0zKRLUi670MCYLXixBwHEs+0VHWgzh1eGx5KJpcUy/VG X-Received: by 2002:aa7:dd4d:: with SMTP id o13mr4717856edw.53.1619185660986; Fri, 23 Apr 2021 06:47:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619185660; cv=none; d=google.com; s=arc-20160816; b=WJi2DapELGqm1ZPQVD8ihQK5azXb6rpMbUpXeG7g8+JWuk24P1/40LDc98nDqg+d/I yoxEJp5D/xncF/5a/9ewn3MxtnSymiXHtab9fMRmElC1Ejgk5NoZebqG9a4XjGAxWOi2 W3116hVVEV6Ck1Kc16Sf9OEWBVvx0ZxMzCkdQRcfDVDV+SOV1cs7IEygAnedhUZv6YAr XfwIO4BetH+nChKPt91EjhvRKWfLbcTPRgRIhngCT+OcwHxOBtEVBypspvGcRKkXK10l cLYOunyFrYZPkR54r3ZdqWQCA34mIuFM6DESfZWiNWWXSrtecvoaF+HPX4C0+QRjcAvp xz8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=tQ+gFSGgwin6cr6B2L3wasr1TG/OCU7qa+e5+WfeZo0=; b=OPwgrj4CBLUR8UwOMW7thzJzus874Ji/xfrdjds4YQDmpk94wtanJHieRBqbeM+hPy MozYm8DgPXKDQ0Jdp/X4cd+ZeYk9GXq0QEd4oWLf6yTE4j1gT5nLhZv4xwzk1e0HGs7A ZfZfxk4lSAsgjZHvk8RYWXh365P/x7SdDb5kyLlqlbT/nP8c1zhGzoUa+SSJ5tfZNHAL uM/rnp+p/Snug9qklVMv07GgGYymiA3+0QPgwTMjhQZqRYwP0Jvh2vHZEy3PQyiiA+W/ GZa6nkrBFhw/Z5DmM+oLDTQ1gY0IzeC/Cw1S1d5HCcmfGch018NOa9cPQz4IOZ8lZtJ8 Ejwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q23si5369380ejm.194.2021.04.23.06.47.17; Fri, 23 Apr 2021 06:47:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbhDWNop (ORCPT + 99 others); Fri, 23 Apr 2021 09:44:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:56646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239670AbhDWNoQ (ORCPT ); Fri, 23 Apr 2021 09:44:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7DCC861175; Fri, 23 Apr 2021 13:43:37 +0000 (UTC) Date: Fri, 23 Apr 2021 14:43:35 +0100 From: Catalin Marinas To: Lorenzo Pieralisi Cc: Marc Zyngier , Sudeep Holla , Hanjun Guo , dann frazier , Fu Wei , Len Brown , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 0/2] arm64: ACPI GTDT watchdog fixes Message-ID: <20210423134334.GO18757@arm.com> References: <20210421164317.1718831-1-maz@kernel.org> <20210422142334.GA24087@lpieralisi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422142334.GA24087@lpieralisi> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 03:23:42PM +0100, Lorenzo Pieralisi wrote: > On Wed, Apr 21, 2021 at 05:43:15PM +0100, Marc Zyngier wrote: > > Dann recently reported that his ThunderX machine failed to boot since > > 64b499d8df40 ("irqchip/gic-v3: Configure SGIs as standard > > interrupts"), with a not so pretty crash while trying to send an IPI. > > > > It turned out to be caused by a mix of broken firmware and a buggy > > GTDT watchdog driver. Both have forever been buggy, but the above > > commit revealed that the error handling path of the driver was > > probably the worse part of it all. > > > > Anyway, this short series has two goals: > > - handle broken firmware in a less broken way > > - make sure that the route cause of the problem can be identified > > quickly > > > > Thanks, > > > > M. > > > > Marc Zyngier (2): > > ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure > > ACPI: irq: Prevent unregistering of GIC SGIs > > > > drivers/acpi/arm64/gtdt.c | 10 ++++++---- > > drivers/acpi/irq.c | 6 +++++- > > 2 files changed, 11 insertions(+), 5 deletions(-) > > Patch(2) needs an ACK from Rafael - usually these patches go via > the ARM64 tree but I don't think it is compulsory for this series. > > Thank you ! > > Reviewed-by: Lorenzo Pieralisi Thanks Lorenzo. Rafael, if there are no objections, I'll take these two patches in the arm64 tree. -- Catalin