Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4080ac25f6c8ca4088a950eb9d63da641c020941.camel@kepstin.ca>
Subject: Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection
 on AMD processors
From:   Calvin Walton <calvin.walton@kepstin.ca>
To:     Chen Yu <yu.c.chen@intel.com>
Cc:     Borislav Petkov <bp@suse.de>, Terry Bowman <terry.bowman@amd.com>,
        lenb@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, wei.huang2@amd.com, aros@gmx.com,
        rui.zhang@intel.com
Date:   Fri, 23 Apr 2021 10:04:10 -0400
In-Reply-To: <20210423121607.GA426003@chenyu-desktop>
References: <20210419195812.147710-1-terry.bowman@amd.com>
         <20210420020336.GA386151@chenyu-desktop> <20210420080701.GA2326@zn.tnic>
         <20210420131541.GA388877@chenyu-desktop>
         <4cbb1eff77de1e843912267ade4686cfa1acd610.camel@kepstin.ca>
         <20210420143754.GA390118@chenyu-desktop>
         <5cf35f3742d1181421d955174b1aa9434d042c96.camel@kepstin.ca>
         <20210423121607.GA426003@chenyu-desktop>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2021-04-23 at 20:16 +0800, Chen Yu wrote
> 
> Calvin, could you please take a look at the following version if it
> is suitible?

I assume this patch is adapted from my earlier submission of the
complete fix to be an incremental fix on top of the already applied
patch? If so, you are OK to add

Signed-off-by: Calvin Walton <calvin.walton@kepstin.ca>

> From b2e63fe4f02e17289414b4f61237da822df115fb Mon Sep 17 00:00:00
> 2001
> From: Calvin Walton <calvin.walton@kepstin.ca>
> Date: Fri, 23 Apr 2021 17:32:13 +0800
> Subject: [PATCH 3/5] tools/power turbostat: Fix offset overflow issue
> in index
>  converting
> 
> The idx_to_offset() function returns type int (32-bit signed), but
> MSR_PKG_ENERGY_STAT is greater than INT_MAX (or rather, would be
> interpreted as a negative number). The end result is that it hits
> the if (offset < 0) check in update_msr_sum() resulting in the timer
> callback for updating the stat in the background when long durations
> are used to not happen. The similar issue exists in offset_to_idx()
> and update_msr_sum().
> 
> This patch fixes this issue by converting the 'int' type to 'off_t'
> accordingly.

This patch covers all of the places I know about which had type issues
- it should be good. Thanks!

-- 
Calvin Walton <calvin.walton@kepstin.ca>