Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] platform/x86: gigabyte-wmi: add support for B550M AORUS
 PRO-P
To:     Alexey Klimov <aklimov@redhat.com>, thomas@weissschuh.net
Cc:     mgross@linux.intel.com, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210421234156.3942343-1-aklimov@redhat.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <86f6570b-cd92-3256-9fdd-4ef4e4038762@redhat.com>
Date:   Fri, 23 Apr 2021 19:20:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210421234156.3942343-1-aklimov@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 4/22/21 1:41 AM, Alexey Klimov wrote:
> From: Alexey Klimov <klimov.linux@gmail.com>
> 
> From: Alexey Klimov <klimov.linux@gmail.com>
> 
> Add the B550M AORUS PRO-P motherboard description to
> gigabyte_wmi_known_working_platforms.
> 
> Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
> 
> The driver works fine on this motherboard with force_load=1 and
> it seems that temperature values are correct.
> 
> gigabyte_wmi-virtual-0
> Adapter: Virtual device
> temp1:        +30.0°C  
> temp2:        +35.0°C  
> temp3:        +30.0°C  
> temp4:        +32.0°C  
> temp5:        +28.0°C  
> temp6:        +42.0°C
> 
> The patch is created against review-hans branch on platform-drivers-x86.git
> I am available for further testing on this board if required, feel free
> to reach me. Thanks.
> 
>  drivers/platform/x86/gigabyte-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
> index e127a2077bbc..13d57434e60f 100644
> --- a/drivers/platform/x86/gigabyte-wmi.c
> +++ b/drivers/platform/x86/gigabyte-wmi.c
> @@ -138,6 +138,10 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
>  		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
>  		DMI_EXACT_MATCH(DMI_BOARD_NAME, "B550 GAMING X V2"),
>  	}},
> +	{ .matches = {
> +		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
> +		DMI_EXACT_MATCH(DMI_BOARD_NAME, "B550M AORUS PRO-P"),
> +	}},
>  	{ .matches = {
>  		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
>  		DMI_EXACT_MATCH(DMI_BOARD_NAME, "B550M DS3H"),
>