Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <84cafe48637fd1deed7da2cd15eb2f7679545416.camel@redhat.com>
Subject: Re: [PATCH] spi: bcm2835: Fix buffer overflow with CS able to go
 beyond limit.
From:   Nicolas Saenz Julienne <nsaenzju@redhat.com>
To:     Mark Brown <broonie@kernel.org>,
        Joe Burmeister <joe.burmeister@devtank.co.uk>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Fri, 23 Apr 2021 19:34:14 +0200
In-Reply-To: <20210423162055.GE5507@sirena.org.uk>
References: <20210420083402.6950-1-joe.burmeister@devtank.co.uk>
         <c087ba2c-7839-02d1-a522-b104d8ffb8d2@gmail.com>
         <7c9f9376-1a80-b624-7b9e-0f6d04437c02@devtank.co.uk>
         <271ad212-a606-620e-3f0c-d6bff272be3c@gmail.com>
         <380624c4-82f3-0e6e-8cdb-8a9732636db8@devtank.co.uk>
         <20210423115724.GB5507@sirena.org.uk>
         <672e8d77-ee5c-f10f-0bd3-f8708dfc24c8@devtank.co.uk>
         <20210423162055.GE5507@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.0 (3.40.0-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2021-04-23 at 17:20 +0100, Mark Brown wrote:
> On Fri, Apr 23, 2021 at 03:12:11PM +0100, Joe Burmeister wrote:
> > Of course we could just raise BCM2835_SPI_NUM_CS to 8 or more if that is
> > preferred. Does seams like the dynamic solution is less favoured.
> 
> The best thing would be to have it not have a single array of chip
> select specific data and instead store everything in the controller_data
> that's there per-device.

+1

All in all, it would make for a cleaner driver.

-- 
Nicolás Sáenz