Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: T09eh/B26D2waHB2hFfhQRWrSL0IisKvwDwqWFao2aV3CexPOvcpHPfz9kbLfjBRZ45xUOd1/u
 eK5lX1WtnBdw==
IronPort-SDR: Rd8rbBj41QlgCAjE6WWLxorMGiSv/EMASm3WL1f/0BUYG+IWaUpfSkwRD3JQ2QM57beq0HpL3h
 NbdHQ9dGl20w==
From:   "Ismail, Mohammad Athari" <mohammad.athari.ismail@intel.com>
To:     Vladimir Oltean <olteanv@gmail.com>
CC:     Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "Voon, Weifeng" <weifeng.voon@intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 net-next] net: pcs: Enable pre-emption packet for
 10/100Mbps
Thread-Topic: [PATCH v2 net-next] net: pcs: Enable pre-emption packet for
 10/100Mbps
Thread-Index: AQHXN8w75Vo0bmfsFEyfZYnEbB76e6rBNbyAgAAK1lCAAAXiAIAAkBXggACSDYCAAD4QMA==
Date:   Fri, 23 Apr 2021 22:03:58 +0000
Message-ID: <CO1PR11MB4771248BAF7FF5EF4331F688D5459@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20210422230645.23736-1-mohammad.athari.ismail@intel.com>
 <20210422235317.erltirtrxnva5o2d@skbuf>
 <CO1PR11MB4771A73442ECD81BEC2F1F04D5459@CO1PR11MB4771.namprd11.prod.outlook.com>
 <20210423005308.wnhpxryw6emgohaa@skbuf>
 <CO1PR11MB47716991AAEA525773FEAFC8D5459@CO1PR11MB4771.namprd11.prod.outlook.com>
 <20210423181133.cl5ooguhdm5rfbch@skbuf>
In-Reply-To: <20210423181133.cl5ooguhdm5rfbch@skbuf>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ddb435f-c107-449f-166d-08d906a3b226
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2021 22:03:58.6926
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +1CyrQIB/lupHe36LODnyjZEg0pss8i+RjL+0yptuui7eu7L3lfNYMV/5W90McYtKyH/q8OcIoVWlBhZZyX4oMt5X8jSrYCy0j+w+YpKMNy9UYVlOP/rJ0sGw2uyX9+c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2320
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vladimir,

> -----Original Message-----
> From: Vladimir Oltean <olteanv@gmail.com>
> Sent: Saturday, April 24, 2021 2:12 AM
> To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>; Jose Abreu
> <joabreu@synopsys.com>; David S . Miller <davem@davemloft.net>; Jakub
> Kicinski <kuba@kernel.org>; Andrew Lunn <andrew@lunn.ch>; Heiner Kallweit
> <hkallweit1@gmail.com>; Russell King <linux@armlinux.org.uk>; Ong, Boon
> Leong <boon.leong.ong@intel.com>; Voon, Weifeng
> <weifeng.voon@intel.com>; Wong, Vee Khee <vee.khee.wong@intel.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 net-next] net: pcs: Enable pre-emption packet for
> 10/100Mbps
>=20
> On Fri, Apr 23, 2021 at 09:30:07AM +0000, Ismail, Mohammad Athari wrote:
> > Hi Vladimir,
> >
> > > -----Original Message-----
> > > From: Vladimir Oltean <olteanv@gmail.com>
> > > Sent: Friday, April 23, 2021 8:53 AM
> > > To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> > > Cc: Alexandre Torgue <alexandre.torgue@st.com>; Jose Abreu
> > > <joabreu@synopsys.com>; David S . Miller <davem@davemloft.net>;
> > > Jakub Kicinski <kuba@kernel.org>; Andrew Lunn <andrew@lunn.ch>;
> > > Heiner Kallweit <hkallweit1@gmail.com>; Russell King
> > > <linux@armlinux.org.uk>; Ong, Boon Leong <boon.leong.ong@intel.com>;
> > > Voon, Weifeng <weifeng.voon@intel.com>; Wong, Vee Khee
> > > <vee.khee.wong@intel.com>; netdev@vger.kernel.org;
> > > linux-kernel@vger.kernel.org
> > > Subject: Re: [PATCH v2 net-next] net: pcs: Enable pre-emption packet
> > > for 10/100Mbps
> > >
> > > On Fri, Apr 23, 2021 at 12:45:25AM +0000, Ismail, Mohammad Athari wro=
te:
> > > > Hi Vladimir,
> > > >
> > > > > -----Original Message-----
> > > > > From: Vladimir Oltean <olteanv@gmail.com>
> > > > > Sent: Friday, April 23, 2021 7:53 AM
> > > > > To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> > > > > Cc: Alexandre Torgue <alexandre.torgue@st.com>; Jose Abreu
> > > > > <joabreu@synopsys.com>; David S . Miller <davem@davemloft.net>;
> > > > > Jakub Kicinski <kuba@kernel.org>; Andrew Lunn <andrew@lunn.ch>;
> > > > > Heiner Kallweit <hkallweit1@gmail.com>; Russell King
> > > > > <linux@armlinux.org.uk>; Ong, Boon Leong
> > > > > <boon.leong.ong@intel.com>; Voon, Weifeng
> > > > > <weifeng.voon@intel.com>; Wong, Vee Khee
> > > > > <vee.khee.wong@intel.com>; netdev@vger.kernel.org;
> > > > > linux-kernel@vger.kernel.org
> > > > > Subject: Re: [PATCH v2 net-next] net: pcs: Enable pre-emption
> > > > > packet for 10/100Mbps
> > > > >
> > > > > Hi Mohammad,
> > > > >
> > > > > On Fri, Apr 23, 2021 at 07:06:45AM +0800,
> > > > > mohammad.athari.ismail@intel.com
> > > > > wrote:
> > > > > > From: Mohammad Athari Bin Ismail
> > > > > > <mohammad.athari.ismail@intel.com>
> > > > > >
> > > > > > Set VR_MII_DIG_CTRL1 bit-6(PRE_EMP) to enable pre-emption
> > > > > > packet for 10/100Mbps by default. This setting doesn`t impact
> > > > > > pre-emption capability for other speeds.
> > > > > >
> > > > > > Signed-off-by: Mohammad Athari Bin Ismail
> > > > > > <mohammad.athari.ismail@intel.com>
> > > > > > ---
> > > > >
> > > > > What is a "pre-emption packet"?
> > > >
> > > > In IEEE 802.1 Qbu (Frame Preemption), pre-emption packet is used
> > > > to differentiate between MAC Frame packet, Express Packet,
> > > > Non-fragmented Normal Frame Packet, First Fragment of Preemptable
> > > > Packet, Intermediate Fragment of Preemptable Packet and Last
> > > > Fragment of Preemptable Packet.
> > >
> > > Citation needed, which clause are you referring to?
> >
> > Cited from IEEE802.3-2018 Clause 99.3.
>=20
> Aha, you know that what you just said is not what's in the "MAC Merge sub=
layer"
> clause, right? There is no such thing as "pre-emption packet"
> in the standard, this is a made-up name, maybe preemptable packets, but t=
he
> definition of preemptable packets is not that, hence my question.
>=20

Thank you for the knowledge sharing. My guess, this "pre-emption packet" mi=
ght be referring to "preamble" byte in Ethernet frame.=20

> > >
> > > >
> > > > This bit "VR_MII_DIG_CTRL1 bit-6(PRE_EMP)" defined in DesignWare
> > > > Cores Ethernet PCS Databook is to allow the IP to properly
> > > > receive/transmit pre-emption packets in SGMII 10M/100M Modes.
> > >
> > > Shouldn't everything be handled at the MAC merge sublayer? What
> > > business does the PCS have in frame preemption?
> >
> > There is no further detail explained in the databook w.r.t to
> > VR_MII_DIG_CTRL1 bit-6(PRE_EMP). The only statement it mentions is
> > "This bit should be set to 1 to allow the DWC_xpcs to properly
> > receive/transmit pre-emption packets in SGMII 10M/100M Modes".
>=20
> Correct, I see this too. I asked our hardware design team, and at least o=
n NXP
> LS1028A (no Synopsys PCS), the PCS layer has nothing to do with frame
> preemption, as mentioned.
>=20
> But indeed, I do see this obscure bit in the Digital Control 1 register t=
oo, I've no
> idea what it does. I'll ask around. Odd anyway. If you have to set it, yo=
u have to
> set it, I guess. But it is interesting to see why is it even a configurab=
le bit, why it
> is not enabled by default, what is the drawback of enabling it?!

The databook states that the default value is 0. We don`t see any drawback =
of enabling it. As the databook mentions that, enabling the bit will allow =
SGMII 10/100M to receive/transmit preamble properly, so I think it is recom=
mended to enable it for IP that support SGMII 10/100M speed.

>=20
> > >
> > > Also, I know it's easy to forget, but Vinicius' patch series for
> > > supporting frame preemption via ethtool wasn't accepted yet. How are =
you
> testing this?
> >
> > For stmmac Kernel driver, frame pre-emption capability is already
> > supported. For iproute2 (tc command), we are using custom patch based
> > on Vinicius patch.
>=20
> Don't you want to help contributing the ethtool netlink support to the ma=
inline
> kernel though? :)

We are working with Vinicius to have ethtool support for frame pre-emption.=
=20