Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/amdgpu: Added missing prototype
To:     Souptick Joarder <jrdr.linux@gmail.com>, alexander.deucher@amd.com,
        christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        Hawking.Zhang@amd.com, evan.quan@amd.com, Dennis.Li@amd.com,
        luben.tuikov@amd.com, jonathan.kim@amd.com
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <1619213997-5475-1-git-send-email-jrdr.linux@gmail.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
Message-ID: <da39ded9-7222-8530-2388-aef3879d1ca3@amd.com>
Date:   Fri, 23 Apr 2021 19:33:55 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
In-Reply-To: <1619213997-5475-1-git-send-email-jrdr.linux@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.2.100] (142.182.183.69) by YQBPR01CA0029.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.21 via Frontend Transport; Fri, 23 Apr 2021 23:33:57 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e8cbcdd3-b470-4274-87c4-08d906b04440
X-MS-TrafficTypeDiagnostic: BL0PR12MB4963:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BL0PR12MB4963A64EEBC9A337ECE8D8E492459@BL0PR12MB4963.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:54;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yPkxmpg8hNu4psIhVgxR5s2WJvujdIrhHaHPDe6ZUT2a2+DRIcT9fmDRZ3qQqdaBrimMAkWkLAk3vnsNpl8xVhnMcxLI8hS2xmUZrrQG/AYtjX2SkdkRTq5nKRSXgjqbPUEqIdxeY7tNGzdTnohWbu5jJsrs6f1JQuVSOR2XDZGl+JsrP+xsMatOoTAVNiYC5VYIckcPrvZYrvvZlQdvhviHgL4FTeAULjz36M4NN8KpK7qUPLVGt09YJgWN5ENxEW0Q1yozHsm/4bZcL7C3E/HqoJ6ijpLm0+p7tp9UteL4gValHXBA50VjjzO/gfFWx0OPd0qOl2IqwAaukiFcD0YSLSx5RQTqHrMTAE3VO+8jSf2TU+5T9xTavHIjgNDPuFBIwyNfQunq9FN+2dTHIss5teGsA7ldtFbPfi0KwrBFKYH9ScVUbB6pkPdLWIsa2xzn62L1rde02XADJyv4KkDxDfZxRVkbtISLjxzhaDLL/0Gmy2SIur5dElC8aHpNzDG8TOSpMK+Zk9ZCK6ibf5lEu0GTt3l8id3KYp8YAHIXtNZcY/lr9pNhTSESJ7fMTD9/8ww0e6oJ7GJQHtFj18wdMSa+5oo7Zvzgz1liiGyv4/pubMKXHhOSB6yIOYr8IiWoKCqMshQSIjbWC5Wq6JenZg7YtmmSBuI8AbEZQYHgdn/OOiCrnS3KSCPDn4nRTOuLNxbeT2CueBDubbdLdQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB4948.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(346002)(396003)(136003)(376002)(8936002)(36756003)(2906002)(38100700002)(186003)(31696002)(4326008)(83380400001)(86362001)(6636002)(26005)(5660300002)(16526019)(2616005)(478600001)(921005)(316002)(31686004)(16576012)(44832011)(8676002)(66946007)(956004)(6486002)(66476007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?T1FQYUU2MXVQeXN1MXNad0xPTndadGVQNFNReDdJWHBCcTdtWFNOa3pHUktK?=
 =?utf-8?B?Z3hZalRQY3BBc0wxK0RQZmh2NlhwcEVXa3RxME5LeGRtdGN5N25ibm05MUpG?=
 =?utf-8?B?ZzUwV2FQRzhDUGFvdUYxL05IUHFSa0ZaWFVTN2RCTit0Q3Avd2VuQURVV1dE?=
 =?utf-8?B?N3lXZ1pTY3V1cE9ISk1yTGZ2Qk80eWwrZU01bmx2MkFGN3d3MElVYUV6enNx?=
 =?utf-8?B?c0VpYlVxTUZqNnJYZ1NzL3Zxa01qbytKNStoYi9KRDkvMWo2OENGNmtBdG96?=
 =?utf-8?B?VG42ZWRPZWZpQ09VMjVISmlrK05rcE94YlhjSCtXSmxBREZWR1pQOXFSdzY5?=
 =?utf-8?B?TXlQVkMxK041eFZUQzhIOXpXU2JKMUZ1TE9jaDI4dU5sV3FTTXVYYTdXYjNk?=
 =?utf-8?B?S1ZRNEZQTS9vQlFzRnl4Nm5QaEloMThmd0VwR3dXRGUrMmRHdU1WOGhhL0Nk?=
 =?utf-8?B?MFU5S002NzhkVVNFZDZVdEllOUtKZmZXaVhsSUNITFlsYTZYM3NDbHh4cmhx?=
 =?utf-8?B?eW9BQ3k3WTdUSUNHU3pZUnBXQnd6dWtiU0kwaCtQemZxOXhZRmxxTFVPdzBZ?=
 =?utf-8?B?bWhLaDQ1VS9nQy81Z2t6eXdYQkhGWTZDU244a0hwbU4vTWd4WE5wcVZrbFFU?=
 =?utf-8?B?VEkrR3BNdFhiVjhneEhmUU5Sbm9hTVNmSzZteURURlRWa3NuM2ZPYXRrcEVJ?=
 =?utf-8?B?SFJRZm9HMWpZcU9mN0N3dkRFTld0dzBxbmJFSmdqTDJ2Rm5qdFhJdXBRWG9J?=
 =?utf-8?B?R1lxT1BVVTU2OTlvVjBIMmcrbE1qa1pZWlkzaWFma0VBN1VIVHlsNmo3RUhi?=
 =?utf-8?B?VDRkVXQzLzZxOFg5TWJZaVA4ZTdqSStFSUpiUmFvZmI1TVRoeDNobG9zcEM4?=
 =?utf-8?B?WkdmS25ETU5mRWQ4d2VIQkFrRGJjdnFCTjh0ak5ORW44eE05ekFITjd1Y1RN?=
 =?utf-8?B?MnAwSHRNcWJZaURpY0FTbW0wZWFZZmlBWE5wSDhBWFBYcW85YllxcDlBQnFB?=
 =?utf-8?B?aDhwK2ZoQTIwcjNLUG1mTXBpVEhKU2hKdkpIZmtyVnA2R1JXRGJUcExJMVl3?=
 =?utf-8?B?QnVrRCsrSTJlWGtyN2h6UUhPRlFMbDgwQmNmUEZZZHJFanJtSlp3SXUyajBP?=
 =?utf-8?B?VG1FZFFzYW1Wb0NETmJsNnBXQ1lHY1J0TjA0TGZYNnNtYXRZNStwUzFSMndn?=
 =?utf-8?B?Um1EdUMxakp0bFlTaVh6OXJ0TmRwS1ViZkVwVzIrcFI3emowVTN2WE1KTm9s?=
 =?utf-8?B?UlJuci8yY3JnVk90bHRxUmQ5RTRWQzdKanQvOTk0UXJFNm9UazZWc3R3aFRo?=
 =?utf-8?B?VFFuVTd1VjdZQWphSzhra210YjNmV0NybUl1a2MzMXQxckpiUHZFcGFsWlYv?=
 =?utf-8?B?Z21EenRsSWc0ZXNkTyt6WFQvSndCYi84ZDN6L2JnbFZFd0w0QlpIc09QcHBL?=
 =?utf-8?B?M0x5eDZrQTBZTXlYWWh1QkkrRUl4WE9BeEd3VXJrSStBVmU0RUY3MUpJVXJ4?=
 =?utf-8?B?UTJOWXpURFh6ZEt1Kzl5WlhHT2FrM1F1aCtLdytNbmVCU09tWWpFUExId1Vy?=
 =?utf-8?B?WldiY0JWR0cxU2U3SUs3YWEwcmduTU96NTROeEpyWXZwamwvWmNjcGNZeGJp?=
 =?utf-8?B?RFpJd0swRHl1NWtRdW9BOTk2OHZHZERpSlV3SXZCelVKT0swYlNkcGdsN1Vs?=
 =?utf-8?B?NXdmZnN6djVicDg4K3pKT1pZMWdlUUE1a1I4aTc2UnZQNVpLaUNVNG1DU2do?=
 =?utf-8?Q?jZy2g5rSJG0bj2XF1HaR0mwmoQomdbOgiqUeMUK?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8cbcdd3-b470-4274-87c4-08d906b04440
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB4948.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2021 23:33:58.1285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hbeHWc9f8UiNDgo1/mXaCX1xl0Y968tYOVxK2w+7hRmzZH/dv78nkLbBbzx4kDk4IzXPsbXr7cLAIv07xQD3Jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4963
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2021-04-23 um 5:39 p.m. schrieb Souptick Joarder:
> Kernel test robot throws below warning ->
>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:125:5: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_load'
>>> [-Wmissing-prototypes]
>      125 | int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void
> *mqd,
>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:227:6: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_is_occupied'
>>> [-Wmissing-prototypes]
>      227 | bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd,
> void *mqd)
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:246:5: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_destroy'
>>> [-Wmissing-prototypes]
>      246 | int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void
> *mqd,
>          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Added prototype for these functions.
The prototypes are already defined in amdgpu_amdkfd_arcturus.h. I think
we just need to add a #include in amdgpu_amdkfd_arcturus.c.

Regards,
  Felix


>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index dc3a692..8fff0e7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -316,6 +316,11 @@ int amdgpu_device_ip_wait_for_idle(struct amdgpu_device *adev,
>  				   enum amd_ip_block_type block_type);
>  bool amdgpu_device_ip_is_idle(struct amdgpu_device *adev,
>  			      enum amd_ip_block_type block_type);
> +int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void *mqd,
> +				uint32_t __user *wptr, struct mm_struct *mm);
> +bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd, void *mqd);
> +int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void *mqd,
> +					unsigned int utimeout);
>  
>  #define AMDGPU_MAX_IP_NUM 16
>