Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1944332pxy; Fri, 23 Apr 2021 23:53:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhx6n9w0ellHfbnWDPO3wRKQJo864v2dmvwuU44cdWGL0oSF23M5IOrOwRPPakua60Gksv X-Received: by 2002:a05:6402:51d4:: with SMTP id r20mr8836341edd.112.1619247187332; Fri, 23 Apr 2021 23:53:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619247187; cv=none; d=google.com; s=arc-20160816; b=G6jyprlf/90yWFxcDIu18eiCDum6Hj1UAbGXq629uQBlX+hFkrGxG/WkGh4wCzJj7q HZwRtF3N3t3tVYwlAZ7h/lHZZ7l7n8ogUbEZvN1dVAndLwPnqynezamZx1T7boN/cyoH biOkx/7DeoKjW8wIJwFYpWmVrp2jKT2XRTWRXT9kI228XVnz5iERhgFDa2hkV4X6tJrC jHjk0+WsJDPLSutaAD2Lvy1qtbcUT8yGCPhg/ccxe8powpyz89d9Hkr9J9ZIT9eHzPKp PlvjAHNr5YO5xVAJmIFU+MsxzH+M/sVAhvO9zix+BB5Zjl6j7Wd11VDkeqvAfYp7EgJR qh2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=47HdIqjUJtGUwQDpLtdDo2YUdcfQzgmDsHwVdQxtZ00=; b=tTT4aj2lH/E74ObXB2OfrzMuXplMEXyQLmGLtBYHRFK7nirRdXht+MjsP94cqAkRQD t0QFEzP7DwOujvpJj2xFsT14ELC+d7ziznIbBKrR5+kt0lajJPj5gwuxZYoo5MMw/Wab Q1juJe36W4pAtdaDfsPDfxHr2TMknEQ9oWqbrXhpVZD0QNJpyXoav8XYglmkjRh9jc+g ZByFxxILs4ggIa0buW8VbmrvmdDUP0JTnFdCA14ePs9cG1a8CvD0c2Dga3xzU8t9HYMK AV6TT72DGF6TordOslUFDV3gaRkNyol7msSUZrGn22BnoO4WekAfucS3ui8g7tJHsNia VABg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=MuVoKple; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si7086881edq.222.2021.04.23.23.52.42; Fri, 23 Apr 2021 23:53:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=MuVoKple; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244575AbhDXGue (ORCPT + 99 others); Sat, 24 Apr 2021 02:50:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:35994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233327AbhDXGqQ (ORCPT ); Sat, 24 Apr 2021 02:46:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B382961931; Sat, 24 Apr 2021 06:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619246733; bh=uVFbSBsOFTlNeqpthO6c96NJAUfPhbV6UvOttxV6+5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MuVoKpleTd+o2AQVdMJ/Eel3LkxhdwtMotaGZrO2oHOfLNJqf2cNyBHm1wM90Sktk NmKuLPAWMBeF4k+9H22EvOW7iW+zjvgZan0fJdo6wLu8VLAfCybzO4AtLK8FaHg4Kg Vx61xfHD2gA9SOnq4hSL3N9FR0PfOKLp4ooZbwMIjTi3NWNRyTHlFtVTCus6u9cu2v i6lsDvi3EEX5iM8OSU1ySjSf890O2lhZGpIAkMsEn075JoD/OHbB0S3CBlMa8Rsh63 ROEMWirDxRx7KbjYNfrdOXkygKbjQiiLj58U49zMquXNsilKCgTrtZEg094IDus5O1 pWnAxkJGasdow== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1laC2l-004JfM-S5; Sat, 24 Apr 2021 08:45:31 +0200 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Manivannan Sadhasivam , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 34/78] media: i2c: imx290: use pm_runtime_resume_and_get() Date: Sat, 24 Apr 2021 08:44:44 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx290.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 6319a42057d2..06020e648a97 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -764,11 +764,9 @@ static int imx290_set_stream(struct v4l2_subdev *sd, int enable) int ret = 0; if (enable) { - ret = pm_runtime_get_sync(imx290->dev); - if (ret < 0) { - pm_runtime_put_noidle(imx290->dev); + ret = pm_runtime_resume_and_get(imx290->dev); + if (ret < 0) goto unlock_and_return; - } ret = imx290_start_streaming(imx290); if (ret) { -- 2.30.2