Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1945470pxy; Fri, 23 Apr 2021 23:56:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyH0vncFjWeQqad6JPDFGsZbZV6gx1HGPSNOrjKvHhuCEqvNMn63EKkAE75sI3wvJvuPwk3 X-Received: by 2002:a05:6402:a4a:: with SMTP id bt10mr8716329edb.39.1619247366578; Fri, 23 Apr 2021 23:56:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619247366; cv=none; d=google.com; s=arc-20160816; b=02e+hZz+fj8R3fsp2v5f66UWcqjBs0IeMDgJdZ2hF0Yda6p1ht6k/GEgkE70haDVwq rvFBIcqcKGmt8rZTEasRczcUPs0uYqV18oIN4B7UI2bGu0O9vJ6fhqDsL0C+3N0vzoK0 k2n8clzf/yMY1FXqQa++L7MMfJEFVSqI5Bf/KIEV0mYV8k6t/6LBpD1JWt71ZZNeYKS3 hmDXGfjP7iGTEHvZjnutRII2qof0NpIIVo0mk8RbHSQmw6GQQ8mYNL08/J+Wnd7k82JB Hv+2abyKg/oM7z3gq61zsiz6x1KGtQ+YBlmCkEVmRgEuAaImGTsbeMlLi0t16Qir/peO XvrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=ePRQI2425MZQs32erSgY9grVnVeMgLTf/dJ0ynteMeg=; b=VH09vR0HZUFOhSWHICXfXPxQK0aSGca9IvPj7mkqxEPMbF+aO6bBLRk08DslE34Gmc 0fnoRwGCB3KPhig4lDIXVZDjP88yZdWQ1/1zonIkVbjwEXw56HyZf5uGBpuMRaDX/1Zm gsK2NCI91OWQZpvr856XkVxBIqy5L+6Mq56FQZrya1aGAi8BgYeZ8oGsX7fWmj8r6zsB iYwTniSkKCaV//3KLZWR9r9BwuGyaCt6zWpfPjplwKDVJIAaKNr4e7uZPTDAoAR4LC9r ZLlzXPpZX8ZpXHOS8cmuau3ZhjrmrnwBdMD9aFTGrF6NSpbQlYE5UlT+GCbdPlCliF7q CySw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=KIbr3Sii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zd7si7450081ejb.84.2021.04.23.23.55.42; Fri, 23 Apr 2021 23:56:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=KIbr3Sii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233881AbhDXGvi (ORCPT + 99 others); Sat, 24 Apr 2021 02:51:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:35726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233997AbhDXGqV (ORCPT ); Sat, 24 Apr 2021 02:46:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CA30C6193E; Sat, 24 Apr 2021 06:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619246733; bh=rXQEV5ur3+5U6VOB8wAB6dlcXqNLqRBsrKFm5rfs1io=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KIbr3SiiTvQRZ7RkL4yt6P99Y/WGlTlPtlFwzWn/sGZQlyMHrutQqWVIWqJr2dEP8 0V06/jXowg+wgkvxygqmwDdez7KLiiksMqEA6sY3Riz+oycEB/EwlWPT9YRhNZ5bBv 2mk80Pjh9i++OnQ1UQLSg6P5jAElktGg9E0qh24H+r9C97BDTPzHoMtvMFP98DP1A3 sUtawt6/73xO7B6ob8Iv9r9LlT5L2fea1JjUK7cg4/dl6Q6nPkfYGefr2srakB1UNt QYUZEXroVZYR3ue8Y52rjTFEfupscnxGPV1BWQeUGOiZip6dKR2hVp+zunLN/zZvgd jTkhuwGei51/A== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1laC2m-004Jfb-0N; Sat, 24 Apr 2021 08:45:32 +0200 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Dongchun Zhu , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 39/78] media: i2c: ov02a10: use pm_runtime_resume_and_get() Date: Sat, 24 Apr 2021 08:44:49 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/ov02a10.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c index c47b1d45d8fd..a1d7314b20a9 100644 --- a/drivers/media/i2c/ov02a10.c +++ b/drivers/media/i2c/ov02a10.c @@ -540,11 +540,9 @@ static int ov02a10_s_stream(struct v4l2_subdev *sd, int on) } if (on) { - ret = pm_runtime_get_sync(&client->dev); - if (ret < 0) { - pm_runtime_put_noidle(&client->dev); + ret = pm_runtime_resume_and_get(&client->dev); + if (ret < 0) goto unlock_and_return; - } ret = __ov02a10_start_stream(ov02a10); if (ret) { -- 2.30.2