Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1945487pxy; Fri, 23 Apr 2021 23:56:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfXc12EjO21vahp41jA51JEbW+s+zc3QJ9hkHMXbXEw/TSYuIgalo3xlWyJ33LO68Le+x8 X-Received: by 2002:aa7:8207:0:b029:251:20c1:1861 with SMTP id k7-20020aa782070000b029025120c11861mr7191741pfi.13.1619247369515; Fri, 23 Apr 2021 23:56:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619247369; cv=none; d=google.com; s=arc-20160816; b=rBeoxMCguoGOmeZbK0vkMIks2LuzC6tRy+Obg6rf8JRv9vg9+m+cDz9fY80faIjwYt LY1DJe07KnQydA4kPw38bOEz016T9YkXGyZpXgQ6/YIl+QBn1gUUqJJtIH9j6FGO5Ax4 0+DUWlGksX1gXEJL8Y/bv3d+0bXGQCSJUmB1eGLvQLn8X0Hj5sjjdUoGbkdE3Wrbyde6 HMSTOPaqO24VYw+4hYNXbCUnXC7yZMaZv04HIKqMp6ZOZ1PrFGOfogD+kPOMB8tQF6GQ GRu6ccm2jUKbKlpGYb36TFaUE0FVI8xbXsr56GNwhH1nQuuHe6FEBCJya/+Ut+QlEeM5 oNKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=2v9KmEwd1C/MzAQ5N3HPIngKwEpL5FhNSeMj/4vi0JA=; b=VCIImMxhzvPuCGE1nwK1E7qmC0MUJNUiCLcuP+q/NZ/OdfkOEsQ9VAlPLhMUu/E9pA qtkap6HzC1HVqGOmLfh/DE56FuEzqKKPJaCXIzE/oPDIUChmv564bcwELgqETXn5+UDH 7r8vwSV8JVmX1y+tXnjVQTiMjacOiooUfAWokQidPzkYkSIdcvOp1f6Op7H47PSKeD2u WtDn+uwg1m48Pyj1HuVIg0YDu5G8acz0zYh7SmGneWzwAkcUMegxppib62iewSlahLnh skYpU0gyjPq8SY2/Q+w5m5nDO8wlJa1E3ZjK2d45vwDnY84MyHzHQQ43rOGOGWZdTYwF w25Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=GVrdrc5O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si13169672pjv.27.2021.04.23.23.55.57; Fri, 23 Apr 2021 23:56:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=GVrdrc5O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244877AbhDXGzD (ORCPT + 99 others); Sat, 24 Apr 2021 02:55:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:35870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237218AbhDXGql (ORCPT ); Sat, 24 Apr 2021 02:46:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EFFA56195A; Sat, 24 Apr 2021 06:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619246734; bh=HzlriyHzqlZAHsYOJEVourXS9CSW2DolwRX6O+Dbyqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GVrdrc5OimlaxC6opChoqdFRAlbPB1BNRFjPJXeW7rKz4/Y8Ubpb7IR1AeWIue7EE 1AbE8wwsAvIrb/rdYUuFZT51Sa2LZ/MzgioT/y4N+0MXNzjmOSBPQKR/rja63+eWvY YT1TD1WSOR32R6OQ5zLWWTdxj0AVD0g9vdqvREINu9JXeTFxJ4clU9+L3zJu48mIy/ ydwGOPHeKgA2HcTfQWnRg96aoZDlcAJ27Rt20akKuCU1q5jzkkARtrpkjsHse4NXTP b0Ich01R3n2qDuVgWCzpasiBZjx0cu1HYSgX1OQzGXXVVA1fzImiMQtNKkjc8D2TxU mmk4jhLsCgZqA== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1laC2n-004Jih-Kx; Sat, 24 Apr 2021 08:45:33 +0200 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Kieran Bingham , Laurent Pinchart , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH 78/78] media: vsp1: use pm_runtime_resume_and_get() Date: Sat, 24 Apr 2021 08:45:28 +0200 Message-Id: <967b4268e89ebd073af3f68898aa7de66a23d9e6.1619191723.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/vsp1/vsp1_drv.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c index aa66e4f5f3f3..c2bdb6629657 100644 --- a/drivers/media/platform/vsp1/vsp1_drv.c +++ b/drivers/media/platform/vsp1/vsp1_drv.c @@ -561,11 +561,9 @@ int vsp1_device_get(struct vsp1_device *vsp1) { int ret; - ret = pm_runtime_get_sync(vsp1->dev); - if (ret < 0) { - pm_runtime_put_noidle(vsp1->dev); + ret = pm_runtime_resume_and_get(vsp1->dev); + if (ret < 0) return ret; - } return 0; } -- 2.30.2