Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp1946547pxy; Fri, 23 Apr 2021 23:58:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy86AiU5h0vWJWS5TPSPn9KWq0M7d0jUWxWlayru9HXA73xbbs64Meyos9rpY1GgQleAikk X-Received: by 2002:a50:cdd1:: with SMTP id h17mr8727624edj.178.1619247529096; Fri, 23 Apr 2021 23:58:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619247529; cv=none; d=google.com; s=arc-20160816; b=0KqnmyQxpoLBOrw8U51CwH9UnvPL6APLITrRNgNmnAE4/6HdU+oAq32XH8EjlFEEk7 XQCHumpUZmRWDYDnkCbNXqKMAyDdjh3kmK/chLfvCHU1FuP7DZCagAgACrFsJf3YVR+p pQO0JtQfJhRSRtCdfWYFQFvm26DvmFScvphzQeyUeoLi75bAWxAlYZUfKLkPznquWI2B PipirAUO6E0QL7lNwm5suJ9jZAfiAX2QGR8VVEXfWEi3XuD7e0z4IvCHfKTUXD1KV+Lg IYU3+q7jhi2rTnk364tqjx6rWIqiVTwPRYVyigI9nW+nlOWzlM6j9BPKQO3LVfMo60K0 BFDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=l0nFwYPWPiXFHgUKHwaK5u28Bc2/mwKnyZYYdjE5Uoc=; b=O3MqLyN9tvw6rbuy9etTRZAl1iR7kw84RqTfl5hCW3s5BGQRpE1O1GmBVZJ3PmXKtK tZU7StkA+hQoMxicjTacB1FN7bUvD/4fksrE3tPdnSBz/98Ok2sh+10FYcvgHO8w23QW pK4IW9FnovzhFiErEsoHCpuk38/qrCEFsXQyrOTj9TpsOV/ACvhpYKcQN/3JooSILkj5 5HPpmrJHw9+Mw5M1ugZPPzsZholxSXljs/2pY1FmLePpI8dzPKp+1KHs/5O++sCYpJtw gSVmstgzOJTstH7ReS5e+4VZr0w9fJKdsosXOupPDf18seDYSqP0gdnwTOEWRWr2sEtZ XADg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=uNkl+dN0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u16si8574081eje.91.2021.04.23.23.58.25; Fri, 23 Apr 2021 23:58:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=uNkl+dN0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244952AbhDXGzQ (ORCPT + 99 others); Sat, 24 Apr 2021 02:55:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:35962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237278AbhDXGqr (ORCPT ); Sat, 24 Apr 2021 02:46:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF8F061958; Sat, 24 Apr 2021 06:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619246734; bh=oAi5YzlfFlQMfzPh3wYGQ2xjGcqBCgu57W3dE0PjRzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uNkl+dN0ZRAmPjBVUxvRFDV2HDRh3KZlriRG4hOYai5IVLtXLrMkRMp6XWHRnFkg0 lVt5LRch0xVyRgiORC3DX3lhyIpbxGleKR07+rQLx8gOa2j8utqDM6Dzf95UdYX3oo 8ZLbtpCIOAGfPp9veV4hdIld+/ze6px/ScFuXEJMhiXvCmX91uTZHoG6kyEOGiU7ax J2bzYIL58bH0AohybiiQhzHCZsAFxG5q9OCtdxoluApTs+OQs7oyEoAguIOX/VtlKp 9ZwUTN6St0fmcuyXwiPXpfR5cIEUNpvInEpgPX2ZN8rCIFzl414T9KptmS9kMi/mwm Akdltj3aKkCzw== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1laC2m-004JgB-Bh; Sat, 24 Apr 2021 08:45:32 +0200 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Colin Ian King , Hans Verkuil , Mauro Carvalho Chehab , Paul Kocialkowski , Sakari Ailus , Yang Li , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 51/78] media: i2c: ov8865: use pm_runtime_resume_and_get() Date: Sat, 24 Apr 2021 08:45:01 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/ov8865.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c index 9ecf180635ee..3bf6ee4898a9 100644 --- a/drivers/media/i2c/ov8865.c +++ b/drivers/media/i2c/ov8865.c @@ -2497,11 +2497,9 @@ static int ov8865_s_stream(struct v4l2_subdev *subdev, int enable) int ret; if (enable) { - ret = pm_runtime_get_sync(sensor->dev); - if (ret < 0) { - pm_runtime_put_noidle(sensor->dev); + ret = pm_runtime_resume_and_get(sensor->dev); + if (ret < 0) return ret; - } } mutex_lock(&sensor->mutex); -- 2.30.2