Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <295686a0-240d-71d1-a6a0-f3752cf24477@gmail.com>
In-Reply-To: <295686a0-240d-71d1-a6a0-f3752cf24477@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 24 Apr 2021 13:25:54 +0300
Message-ID: <CAHp75VcLoTsjyQyVAo6cd+HMd+z_irM8ofcenRm0P6CzYGOQNw@mail.gmail.com>
Subject: Re: Support for AMDI0022 UART
To:     Maximilian Luz <luzmaximilian@gmail.com>
Cc:     "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Wang Hongcheng <annie.wang@amd.com>, Ken Xue <Ken.Xue@amd.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 23, 2021 at 10:58 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>
> Hi all,
>
> I received a report from a Surface Laptop 4 which has a UART that is
> identified as AMDI0022 in ACPI [1] and that does not seem to be
> supported by the kernel yet.
>
>  From what I can tell via ACPI, this is similar to the AMDI0020 [2] UART
> that's already supported by the kernel (well, both are devices with two
> MMIO regions and an interrupt as far as I can tell...). So it's possible
> that all that's needed is adding it to the respective device ID lists
> [3, 4]. Unfortunately, I a) don't have a device to test this myself, b)
> haven't found any more details on that online, and c) don't want to tell
> others to test this without knowing a bit more about that (potentially
> writing random stuff to some unknown MMIO region that I don't know
> anything about doesn't sound as safe to me as I'd like).

To me they look completely the same. Depending on the device which is
connected to the UART, I would suggest just to add an ID and see if it
makes it work.

> Does anyone here have some pointers on what it'd take to support this,
> or any contacts at AMD that could provide more insight?

-- 
With Best Regards,
Andy Shevchenko