Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 24 Apr 2021 15:02:00 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc:     Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Rob Herring <robh+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Aswath Govindraju <a-govindraju@ti.com>,
        Vadym Kochan <vadym.kochan@plvision.eu>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] misc: eeprom_93xx46: Add new at93c56 and at93c66
 compatible strings
Message-ID: <YIQWyDuWTfL3Eqp9@latitude>
References: <20210424123034.11755-1-linkmauve@linkmauve.fr>
 <20210424123034.11755-2-linkmauve@linkmauve.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="sopQoswJR2Pf33wk"
Content-Disposition: inline
In-Reply-To: <20210424123034.11755-2-linkmauve@linkmauve.fr>
Precedence: bulk


--sopQoswJR2Pf33wk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 24, 2021 at 02:30:30PM +0200, Emmanuel Gil Peyrot wrote:
> These two devices have respectively 2048 and 4096 bits of storage,
> compared to 1024 for the 93c46.
>=20
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> ---
>  .../bindings/misc/eeprom-93xx46.txt           |  3 +++
>  drivers/misc/eeprom/eeprom_93xx46.c           | 21 ++++++++++++++++++-
>  include/linux/eeprom_93xx46.h                 |  3 +++
>  3 files changed, 26 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/D=
ocumentation/devicetree/bindings/misc/eeprom-93xx46.txt
> index 7b636b7a8311..72ea0af368d4 100644
> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> @@ -2,7 +2,10 @@ EEPROMs (SPI) compatible with Microchip Technology 93xx4=
6 family.
> =20
>  Required properties:
>  - compatible : shall be one of:
> +    "atmel,at93c46"
>      "atmel,at93c46d"
> +    "atmel,at93c56"
> +    "atmel,at93c66"
>      "eeprom-93xx46"
>      "microchip,93lc46b"
>  - data-size : number of data bits per word (either 8 or 16)

The DT binding patch should ideally be separate from the driver patch.

> diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/ee=
prom_93xx46.c
> index 80114f4c80ad..64dd76f66463 100644
> --- a/drivers/misc/eeprom/eeprom_93xx46.c
> +++ b/drivers/misc/eeprom/eeprom_93xx46.c


other than that, the patch looks fine to me, AFAICT.


Thanks,
Jonathan

--sopQoswJR2Pf33wk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmCEFr8ACgkQCDBEmo7z
X9uCHQ/+PKHNjXQ9DCtGu0hrrdbXktP6m5IgpDU44oF2VJxcYE0l+Jq2gf0f0yt7
nUMkH7g2dbX3zHaV+V+4RMPFqSmNWm6ei8IzZY1AuRN7Y1TmTX5ArvEIfHp95G9i
65cAqOyV8o8wyoXFoc+NSlA3D8py0cqPxg5tygjVqnAJGpnMRqLp/4PhbeQmZlGW
qbZ1VsNfrxk+jmHEAn7xwJjvrFKaZCR9FY78k0jKPQTiTD8XDlj9OfmsFc+M3I6L
CPbbp5zpgQeqWTcCNzqwEqw5+A11PLUQfgn6JpHB+cvLDhhhXLH8V1Z65YUguwwJ
6DkydwQvpayFCWTX7dC2GLkFZzIkFH3B+KWiPbjrXb9WGAO6dYIqTBmkOPS782Ct
uKOod0i0Fpn6KwPjme9oXUwJZy5I7qPgnwGj8LuTK6kS4bioY0hvvWAIgl3TDgEv
CrZt0oxic4bMsW88SkWOsemZovJgMZuM/gKXukuR1YOHkBEGK10tmdC6mdVo6ZzZ
P+hWXyxKhqr+SHUEKbgGrnStJBokjVY7cCe4hbo3aBfz6w7Ri0u0xsIhUcSq74p2
ghIpj5ZzyATX0M8RAsbrs23dH4p+qsocYiMMPtgVlKirG5u84qnnrPebh7MzYO3v
dd8EijnBpKh0uP5guXo3JlAG9STOpNs1EEhxldHW+15y1dr6GBE=
=rQN8
-----END PGP SIGNATURE-----

--sopQoswJR2Pf33wk--