Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 24 Apr 2021 15:42:23 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc:     Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Rob Herring <robh+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Aswath Govindraju <a-govindraju@ti.com>,
        Vadym Kochan <vadym.kochan@plvision.eu>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] misc: eeprom_93xx46: Switch based on word size, not
 addrlen
Message-ID: <YIQgPwtzaEJDprHo@latitude>
References: <20210424123034.11755-1-linkmauve@linkmauve.fr>
 <20210424123034.11755-5-linkmauve@linkmauve.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mF+lD7BQt1FLCE++"
Content-Disposition: inline
In-Reply-To: <20210424123034.11755-5-linkmauve@linkmauve.fr>
Precedence: bulk


--mF+lD7BQt1FLCE++
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 24, 2021 at 02:30:33PM +0200, Emmanuel Gil Peyrot wrote:
> This avoids using magic numbers based on the total size and length of an
> address, where we only want to differentiate between 8-bit and 16-bit,
> and finally makes 93c56 and 93c66 usable!
>=20
> If the two pointer indirections is too much, we could move the flags to
> the main struct instead, but I doubt it=E2=80=99s going to make any sensi=
ble
> difference.
>=20
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> ---

Ah, this somewhat addresses my reply to the previous patch.
I think by rearranging and/or squashing the patches, they could tell a
more coherent story, and cause less confusion.

(Basically: avoid creating conditions where the code is wrong =E2=80=94 if a
 later patch is needed in order to make a previous patch correct, but the
 later patch alone wouldn't make the code incorrect, swap them. If there's
 breakage either way and you can't tease them apart, squash them together.)


Thanks,
Jonathan

--mF+lD7BQt1FLCE++
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmCEID8ACgkQCDBEmo7z
X9vTaRAAsXPixWA1V+sKf7bVhbGsOdJmZkLSze1UvUIuAFWJRQVK2hMAjvauN0iJ
G6Gc572a5qZ4sLK2MEkukWLh9Z4x/aFaxDlcS3w0VABoLUwuvxdfFPaadiyKwtsY
QLKSRie1J7Q3qEuGtNK1s9Z/+3Qm/1AXd7LdrB8k2FFsaQPAmb6YsgtyxaHcMSux
asi8irRGxVWhdu7Ez3vxOslfHvu5ijvR3+DBqech2eCWmR7tWGlVYobyLs3dNmtV
qOmn+NZf9rajkuWc/2FZHKdP4/DU5yXoOQylc9LlkFG4zPCS9dxFkrtJyQuYl6Bx
IusNHeq+F+XyoIluKkA7gocx3Wr6XgpL0Rq+lTr2abjs0JhDXJPmzTZzo6NgJB9O
ZrCExHjI4cu3hGGWG/niKR3SkQo+YCzk5AsSkZJt5BZAI2Yy9/N3wncF8PoZ1x+L
sfHZ7L+DsFNqpRKUGRqAUGbpMilT0yoq+ZfNQ5orrC5inK1mpzQnEpdYTOkk7uBv
R2IWGXmel9gDjAmXfL7jXsWwGcKV0BF7nlhJVqeNplQpshlHDKtCFYKnFnp25QWI
ngRzxGyGveW41MocDzrFOwYJuffI0GJNslak+sTl0Y9ZmD/drdUVcs9UWDJIh8iR
U3C514IBjQVc5NulMA5oVysJTCpw3TJOX2+BOe1frMAqHR4IaFI=
=UwN5
-----END PGP SIGNATURE-----

--mF+lD7BQt1FLCE++--