Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp2229208pxy; Sat, 24 Apr 2021 08:56:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSTj5AULZWuf7bWMOFsS3tEA9pQlcdP1GgRhlzk/TqU2EYA+A5jGpppWYHD+lDKUBscxH8 X-Received: by 2002:a17:902:8688:b029:ea:f782:5eae with SMTP id g8-20020a1709028688b02900eaf7825eaemr9354180plo.15.1619279780751; Sat, 24 Apr 2021 08:56:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619279780; cv=none; d=google.com; s=arc-20160816; b=O1DYH+iIsL80YkxZoeHU1rxdn7in4xWYvoUDVaQcmJ+H/doy/l1zQKN/KQG30z7da3 2gjk8t8iKwKFos/+GpI7BZH6ujpNsElqUMPielyKiatejd9bXKwE6lN1PH4ZDa7mVLkA 3Ly7gCsCdJeWJncWMku8SwjoIIELt6IBOzDsDNDyRTqwQrSyvZ/YVb2vsXDdI0y4jnXo ZYs9W3FlXa1SKFub2p8W4hYawjwtXwiM1skJhB3h3wGrnd34RyFLPce8xOFpf4Zekbvm q343XEgPanFstePPorlCzeV7OLeVHSm0TvkXYgq2VlCz5uv7bYe/rb6hnNClXGrbS8Uz SKrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=RX/zfd0Emikm947t70sok+od71sC4o8m6m016T+TKLA=; b=CJyaDe5G3Un8yRqD4OU4L2Zhi9BhDbh+R59U5r/fyxc8ZOExZFMd34Tah6BAsp+sTs FeTu4cztro9G/u7s4NIT+5oSvUXL0V2Yl+7sJraCtVAzOqf1Ym+TbUfU+bIYeL1llIn/ hOINokgmCHu6j+yiQ7JMWKr7yrfXvI8/wjHI+/AZgAGGNqzIERyymGCXjx0hCLfI/4j4 +U+LHjVRPJwr2SRdPn4IpEecsnChxlT1NhHXHx0hfEvaKQf0kNnTvSL3RqUobP6OlpnK v5HsqcXfJaRrtFtT6fIPOMc83Sdxiu1NQ1hFvn9cLPnGivWKQTtFStbLk1joLWHqfg8X iDaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n9si22546plf.175.2021.04.24.08.56.08; Sat, 24 Apr 2021 08:56:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233676AbhDXPza (ORCPT + 99 others); Sat, 24 Apr 2021 11:55:30 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:39370 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbhDXPz1 (ORCPT ); Sat, 24 Apr 2021 11:55:27 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1laKcF-000pnO-Nd; Sat, 24 Apr 2021 17:54:43 +0200 Date: Sat, 24 Apr 2021 17:54:43 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Florian Fainelli , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Michael Grzeschik , kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King Subject: Re: [PATCH net-next v6 05/10] net: dsa: microchip: Add Microchip KSZ8863 SPI based driver support Message-ID: References: <20210423080218.26526-1-o.rempel@pengutronix.de> <20210423080218.26526-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423080218.26526-6-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static int ksz8795_spi_probe(struct spi_device *spi) > { > + const struct regmap_config *regmap_config; > + struct device *ddev = &spi->dev; > + struct ksz8 *ksz8; > struct regmap_config rc; > struct ksz_device *dev; > - int i, ret; > + int i, ret = 0; More malformed trees. Once fixed, add my Reviewed-by: Andrew