Received: by 2002:a05:6a10:a841:0:0:0:0 with SMTP id d1csp2232203pxy; Sat, 24 Apr 2021 09:01:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweEo83ty3nJQNjo3v29E8Q37gdNpTrqoiYt1i20JGBblMhmh1iCXeSC/BdDxq9JlUg4B0L X-Received: by 2002:a05:6402:2810:: with SMTP id h16mr10688206ede.107.1619280104811; Sat, 24 Apr 2021 09:01:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619280104; cv=none; d=google.com; s=arc-20160816; b=SP/l9r5k+5LBYckEKVOt1oxClig4AmGQVUQY9Lpfd2d7BVFJr9+maubfq6u/ylKMIh XgoXhhppFNvlh/Yqw2Q3Hi78sLt0SECNBSmw40jn5oh7hNcpf6R9/WGz/oVLwe8U3lVm l+U2sPfHppse1jjeWsZS4YD23DfAr2twKcFmnYANZqGxMBfI54Wt+CZb6nUJkeatqkkn j8P6ZBfWcsp2cRG98TckJnPaDo5rfGmR1oMYM+EsvoGRo+NdHRHQhoQ+PPFsyKssJ5J2 zv19mMDmHwIqrLUaDx27cnpAMg5t0+h2CE8834PZKjPUfXZstAl33ukVNXJDjtmb9/po vNpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:to:from; bh=BsDrlD6UyMfVKktYtGnIvExz7HVESSZguHJRXitZzJ0=; b=lq6ceM1lAGfzJVYvh+tQ/3KTBF2W8SWnLSaYw4TlcPL89BXiDICX3yvUds36J4L91N xayAFwaZw2eU886xJD65Te6QMm0Po1+aOi7dymfTciqBSmGbVzCcW6w5EuI5cjyOvQIK 3FqoGza547isYE2ycThVRE5L8gj4ltnkpCA2vBRYXBOkbMxBn+1D3u18UEf0VmFiLqej A3vXNE7/ndXRR4j22dw6tqVU9SScAoCbOgz//S/tGHhxB0lL1Eud1yBcsV1fxjjHoNK9 jdFlMSO7PuLEGKALC8OS2mq3v9bp8TZ8Zqjf8+h9VtqWwpRiZX3pOUcdDFbINwMw8fY9 iM2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si8203673ejs.275.2021.04.24.09.01.21; Sat, 24 Apr 2021 09:01:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233733AbhDXQAq (ORCPT + 99 others); Sat, 24 Apr 2021 12:00:46 -0400 Received: from mail-m118208.qiye.163.com ([115.236.118.208]:60036 "EHLO mail-m118208.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbhDXQAn (ORCPT ); Sat, 24 Apr 2021 12:00:43 -0400 Received: from ubuntu.localdomain (unknown [36.152.145.182]) by mail-m118208.qiye.163.com (Hmail) with ESMTPA id A9872E00EB; Sun, 25 Apr 2021 00:00:02 +0800 (CST) From: zhouchuangao To: Thomas Bogendoerfer , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, zhouchuangao , linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG. Date: Sat, 24 Apr 2021 08:59:50 -0700 Message-Id: <1619279992-81335-1-git-send-email-zhouchuangao@vivo.com> X-Mailer: git-send-email 2.7.4 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZQh5LQlZJHk1NSR5PGk5LSk1VEwETFhoSFyQUDg9ZV1kWGg8SFR0UWUFZT0tIVUpKS0 hKTFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NU06Lyo*Mz8VEgMDLxIxPhQz FTQaFAtVSlVKTUpCSUNLS0tISk5OVTMWGhIXVQETFA4YEw4aFRwaFDsNEg0UVRgUFkVZV1kSC1lB WUhNVUpOSVVKT05VSkNJWVdZCAFZQUlJTkI3Bg++ X-HM-Tid: 0a79049bff232c17kusna9872e00eb Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BUG_ON uses unlikely in if(), it can be optimized at compile time. Usually, the condition in if() is not satisfied. In my opinion, this can improve the efficiency of the multi-stage pipeline. Signed-off-by: zhouchuangao --- arch/mips/bcm63xx/gpio.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/mips/bcm63xx/gpio.c b/arch/mips/bcm63xx/gpio.c index 16f353a..5c4a233 100644 --- a/arch/mips/bcm63xx/gpio.c +++ b/arch/mips/bcm63xx/gpio.c @@ -43,8 +43,7 @@ static void bcm63xx_gpio_set(struct gpio_chip *chip, u32 *v; unsigned long flags; - if (gpio >= chip->ngpio) - BUG(); + BUG_ON(gpio >= chip->ngpio); if (gpio < 32) { reg = gpio_out_low_reg; @@ -70,8 +69,7 @@ static int bcm63xx_gpio_get(struct gpio_chip *chip, unsigned gpio) u32 reg; u32 mask; - if (gpio >= chip->ngpio) - BUG(); + BUG_ON(gpio >= chip->ngpio); if (gpio < 32) { reg = gpio_out_low_reg; @@ -92,8 +90,7 @@ static int bcm63xx_gpio_set_direction(struct gpio_chip *chip, u32 tmp; unsigned long flags; - if (gpio >= chip->ngpio) - BUG(); + BUG_ON(gpio >= chip->ngpio); if (gpio < 32) { reg = GPIO_CTL_LO_REG; -- 2.7.4